Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github: Fix lock threads syntax and permissions. #24708

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

jrasell
Copy link
Member

@jrasell jrasell commented Dec 18, 2024

The parameters used for the reusable action were incorrect since the 5.0.1 update. The permissions were also incorrect as the workflow needs to write to issues and PRs.

Contributor Checklist

  • Changelog Entry If this PR changes user-facing behavior, please generate and add a
    changelog entry using the make cl command.
  • Testing Please add tests to cover any new functionality or to demonstrate bug fixes and
    ensure regressions will be caught.
  • Documentation If the change impacts user-facing functionality such as the CLI, API, UI,
    and job configuration, please update the Nomad website documentation to reflect this. Refer to
    the website README for docs guidelines. Please also consider whether the
    change requires notes within the upgrade guide.

Reviewer Checklist

  • Backport Labels Please add the correct backport labels as described by the internal
    backporting document.
  • Commit Type Ensure the correct merge method is selected which should be "squash and merge"
    in the majority of situations. The main exceptions are long-lived feature branches or merges where
    history should be preserved.
  • Enterprise PRs If this is an enterprise only PR, please add any required changelog entry
    within the public repository.

@jrasell jrasell added backport/ent/1.7.x+ent Changes are backported to 1.7.x+ent backport/ent/1.8.x+ent Changes are backported to 1.8.x+ent backport/1.9.x backport to 1.9.x release line labels Dec 18, 2024
@jrasell jrasell self-assigned this Dec 18, 2024
@jrasell jrasell requested review from a team as code owners December 18, 2024 11:26
@jrasell jrasell marked this pull request as draft December 18, 2024 12:04
@jrasell jrasell force-pushed the b-fix-syntax-lock-workflow branch from e10c735 to b118837 Compare December 18, 2024 12:05
The parameters used for the reusable action were incorrect since
the 5.0.1 update. The permissions were also incorrect as the
workflow needs to write to issues and PRs.
@jrasell jrasell merged commit fe821b4 into main Dec 18, 2024
31 checks passed
@jrasell jrasell deleted the b-fix-syntax-lock-workflow branch December 18, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/ent/1.7.x+ent Changes are backported to 1.7.x+ent backport/ent/1.8.x+ent Changes are backported to 1.8.x+ent backport/1.9.x backport to 1.9.x release line
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants