Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add override to force prettier 5.0 #24791

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Conversation

rmainwork
Copy link
Contributor

@rmainwork rmainwork commented Jan 6, 2025

This fixes an issue with prettier incorrectly causing pre-commit hooks to fail

Description

Fixes an issue raised on the back of #24783 where an older version of prettier was causing the pre-commit hooks to (incorrectly) fail when changes were made to redirects.js.

Testing & Reproduction steps

  1. Check out main and attempt to commit a change to redirects.js
  2. Observe that the pre-commit hooks fail (error from Husky and eslint)
  3. Check out this branch and verify that the pre-commit hooks pass

Links

Contributor Checklist

  • Changelog Entry If this PR changes user-facing behavior, please generate and add a
    changelog entry using the make cl command.
  • Testing Please add tests to cover any new functionality or to demonstrate bug fixes and
    ensure regressions will be caught.
  • Documentation If the change impacts user-facing functionality such as the CLI, API, UI,
    and job configuration, please update the Nomad website documentation to reflect this. Refer to
    the website README for docs guidelines. Please also consider whether the
    change requires notes within the upgrade guide.

Reviewer Checklist

  • Backport Labels Please add the correct backport labels as described by the internal
    backporting document.
  • Commit Type Ensure the correct merge method is selected which should be "squash and merge"
    in the majority of situations. The main exceptions are long-lived feature branches or merges where
    history should be preserved.
  • Enterprise PRs If this is an enterprise only PR, please add any required changelog entry
    within the public repository.

This fixes an issue with prettier incorrectly causing pre-commit hooks
to fail
Copy link
Contributor

@aimeeu aimeeu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for resolving my issue and creating this PR!

@aimeeu aimeeu added theme/docs Documentation issues and enhancements theme/website nomadproject.io infrastructure issues and enhancements labels Jan 7, 2025
@RubenSandwich RubenSandwich merged commit 894b32f into main Jan 8, 2025
22 checks passed
@RubenSandwich RubenSandwich deleted the rm/version-bump-prettier branch January 8, 2025 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme/docs Documentation issues and enhancements theme/website nomadproject.io infrastructure issues and enhancements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants