Backport of keyring: warn if removing a key that was used for encrypting variables into release/1.9.x #24794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkazmierczak
approved these changes
Jan 7, 2025
pkazmierczak
deleted the
backport/f-warn-if-removing-used-encryption-key/seemingly-tough-akita
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #24766 to be assessed for backporting due to the inclusion of the label backport/1.9.x.
The below text is copied from the body of the original PR.
This PR adds an additional check in the
Keyring.DeleteRPC to make sure we're not trying to delete a key that's been used to encrypt a variable. It also adds a-forceflag for the CLI/API to sidestep that check.Resolves #24591
Internal ref: https://hashicorp.atlassian.net/browse/NET-11829
Overview of commits