Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client: move 'waiting for previous alloc to terminate' log messages to info #24804

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

pkazmierczak
Copy link
Contributor

@pkazmierczak pkazmierczak commented Jan 8, 2025

I'm not a 100% sure if this is the right move, but seeing as some users are hit by bugs that cause allocations to be stuck in pending state, they are forced to run agents with debug log levels which is very noisy.

On the other hand, having these messages at info will significantly increase the noise of that level. I welcome comments and opinions on whether that's the right way to handle this issue.

Resolves #24788

@pkazmierczak pkazmierczak requested review from tgross and jrasell January 8, 2025 11:12
@pkazmierczak pkazmierczak requested review from a team as code owners January 8, 2025 11:12
@pkazmierczak pkazmierczak added backport/ent/1.7.x+ent Changes are backported to 1.7.x+ent backport/ent/1.8.x+ent Changes are backported to 1.8.x+ent backport/1.9.x backport to 1.9.x release line labels Jan 8, 2025
Copy link
Member

@tgross tgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pkazmierczak pkazmierczak added this to the 1.9.x milestone Jan 8, 2025
@pkazmierczak pkazmierczak merged commit 7726ae6 into main Jan 8, 2025
39 checks passed
@pkazmierczak pkazmierczak deleted the f-waiting-for-previous-alloc-log-info branch January 8, 2025 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/ent/1.7.x+ent Changes are backported to 1.7.x+ent backport/ent/1.8.x+ent Changes are backported to 1.8.x+ent backport/1.9.x backport to 1.9.x release line
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Debug Log Level is Required to see "waiting for remote previous alloc to terminate" messages
2 participants