Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove remote task execution code #24909

Merged
merged 7 commits into from
Jan 29, 2025
Merged

remove remote task execution code #24909

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
1a4785f
remove remote task execution code
mismithhisler Jan 21, 2025
63d18d7
regenerate proto
mismithhisler Jan 21, 2025
80c7deb
update go mod
mismithhisler Jan 21, 2025
411df4a
reserve remote_tasks protobuf field
mismithhisler Jan 21, 2025
063bbac
removes taskHandle and related functions
mismithhisler Jan 22, 2025
1b156c5
adds changelog and upgrade guide
mismithhisler Jan 23, 2025
d156c6c
fix spelling error
mismithhisler Jan 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
128 changes: 0 additions & 128 deletions client/allocrunner/taskrunner/remotetask_hook.go
View file
Open in desktop

This file was deleted.

6 changes: 0 additions & 6 deletions client/allocrunner/taskrunner/task_runner.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1364,12 +1364,6 @@ func (tr *TaskRunner) UpdateState(state string, event *structs.TaskEvent) {
tr.logger.Error("error persisting task state", "error", err, "event", event, "state", state)
}

// Store task handle for remote tasks
if tr.driverCapabilities != nil && tr.driverCapabilities.RemoteTasks {
tr.logger.Trace("storing remote task handle state")
tr.localState.TaskHandle.Store(tr.state)
}

// Notify the alloc runner of the transition
tr.stateUpdater.TaskStateUpdated()
}
Expand Down
6 changes: 0 additions & 6 deletions client/allocrunner/taskrunner/task_runner_hooks.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,12 +187,6 @@ func (tr *TaskRunner) initHooks() {
logger: hookLogger,
}))

// If this task driver has remote capabilities, add the remote task
// hook.
if tr.driverCapabilities.RemoteTasks {
tr.runnerHooks = append(tr.runnerHooks, newRemoteTaskHook(tr, hookLogger))
}

// If this task has a pause schedule, initialize the pause (Enterprise)
if task.Schedule != nil {
tr.runnerHooks = append(tr.runnerHooks, newPauseHook(tr, hookLogger))
Expand Down
3 changes: 0 additions & 3 deletions drivers/docker/config_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -646,7 +646,6 @@ func TestConfig_Capabilities(t *testing.T) {
NetIsolationModes: []drivers.NetIsolationMode{"host", "group", "task"},
MustInitiateNetwork: true,
MountConfigs: 0,
RemoteTasks: false,
DisableLogCollection: false,
},
},
Expand All @@ -660,7 +659,6 @@ func TestConfig_Capabilities(t *testing.T) {
NetIsolationModes: []drivers.NetIsolationMode{"host", "group", "task"},
MustInitiateNetwork: true,
MountConfigs: 0,
RemoteTasks: false,
DisableLogCollection: true,
},
},
Expand All @@ -674,7 +672,6 @@ func TestConfig_Capabilities(t *testing.T) {
NetIsolationModes: []drivers.NetIsolationMode{"host", "group", "task"},
MustInitiateNetwork: true,
MountConfigs: 0,
RemoteTasks: false,
DisableLogCollection: false,
},
},
Expand Down
1 change: 0 additions & 1 deletion e2e/e2e_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ import (
_ "github.com/hashicorp/nomad/e2e/parameterized"
_ "github.com/hashicorp/nomad/e2e/periodic"
_ "github.com/hashicorp/nomad/e2e/quotas"
_ "github.com/hashicorp/nomad/e2e/remotetasks"
_ "github.com/hashicorp/nomad/e2e/scaling"
_ "github.com/hashicorp/nomad/e2e/scalingpolicies"
_ "github.com/hashicorp/nomad/e2e/scheduler_sysbatch"
Expand Down
46 changes: 0 additions & 46 deletions e2e/remotetasks/input/ecs.nomad
View file
Open in desktop

This file was deleted.

Loading
Loading