Support canary tags for services in Consul #4200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schmichael
force-pushed
the
f-canary-tags
branch
4 times, most recently
from
e357d1e to
6347cee
Compare
Also refactor Consul ServiceClient to take a struct instead of a massive set of arguments. Meant updating a lot of code but it should be far easier to extend in the future as you will only need to update a single struct instead of every single call site. Adds an e2e test for canary tags.
Guard against Canary being set to false at the same time as an allocation is being stopped: this could cause RemoveTask to be called with the wrong Canary value and leaking a service. Deleting both Canary values is the safest route.
schmichael
force-pushed
the
f-canary-tags
branch
from
6347cee to
0b560b0
Compare
dadgar
approved these changes
Apr 25, 2018
dadgar
reviewed
Apr 25, 2018
nomad/structs/structs.go
Outdated
| @@ -3814,6 +3814,11 @@ func (s *Service) Hash(allocID, taskName string) string { | |||
| io.WriteString(h, tag) | |||
| } | |||
|
|
|||
| // Vary ID on whether or not CanaryTags will be used | |||
| if canary { | |||
| h.Write([]byte{'1'}) | |||
There was a problem hiding this comment.
What do you think about writing "Canary"?
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also refactor Consul ServiceClient to take a struct instead of a massive
set of arguments. Meant updating a lot of code but it should be far
easier to extend in the future as you will only need to update a single
struct instead of every single call site.
Adds an e2e test for canary tags.
Fixes #2920