driver/docker: convert host bind path to os native #6000
Conversation
| @@ -237,7 +237,7 @@ func parseVolumeSpecWindows(volBind string) (hostPath string, containerPath stri | |||
| return "", "", "", fmt.Errorf("not <src>:<destination> format") | |||
| } | |||
|
|
|||
| hostPath = parts[0] | |||
| hostPath = filepath.FromSlash(parts[0]) | |||
There was a problem hiding this comment.
Can you add a comment here explaining why FromSlash is useful here?
There was a problem hiding this comment.
can you help me phrase it, this is what i got
// for nomad to be OS agnostic we allow to supply the host mount path with forward or backward slash
// we then convert the slashes to OS specific slash in the agent side
There was a problem hiding this comment.
@schmichael update the phrasing again
ilyaiqoqo
force-pushed
the
docker-convert-host-paths-to-host-native
branch
4 times, most recently
from
7dcbbbc to
86e1ffa
Compare
relative mounting can be specified using backslashes or forward slashes. so no prior knowledge of host OS is needed for relative volumes mounting
ilyaiqoqo
force-pushed
the
docker-convert-host-paths-to-host-native
branch
from
86e1ffa to
0f47a7d
Compare
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
relative mounting can be specified using backslashes or forward slashes.
so no prior knowledge of host OS is needed for relative volumes mounting