ACL support for scaling APIs #7418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrasell
reviewed
Mar 23, 2020
| "github.com/stretchr/testify/require" | ||
| "testing" | ||
| "time" |
There was a problem hiding this comment.
and a test which seems to reference count diff which makes me think its a real failure. I could be mistaken on these though.
thanks, i didn't notice the lint and i had forgotten about that test failure. sorry to take up the braincycles on that.
cgbaker
force-pushed
the
f-7411-scaling-acls
branch
from
75f5083 to
a6a7e1c
Compare
cgbaker
force-pushed
the
f-7411-scaling-acls
branch
from
cf10543 to
22edfc0
Compare
- read-job-scaling - scale-job - list-scaling-policies - read-scaling-policy updated the read and right policy dispositions, added the new autoscaler disposition
added ACL protection in Job.Scale in Job.Scale, only perform a Job.Register if the Count was non-nil
cgbaker
force-pushed
the
f-7411-scaling-acls
branch
from
22edfc0 to
da3c2a4
Compare
This was referenced Mar 23, 2020
Merged
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new ACL capabilities for autoscaling:
read-job-scalingscale-joblist-scaling-policiesread-scaling-policyUpdated
readandwritepolicy dispositions, added newautoscalerpolicy dispositionUpdated scaling API endpoints to check ACL capabilities
Closes #7411
One fun bit with this one.... because the scaling policies are embedded in the job, I wrote this to allow hitting those endpoints if you would otherwise have been able to see the scaling policies by looking directly at the encapsulating job.