Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e: set an expose service check in connect e2e testcase #7892

Merged
merged 1 commit into from
May 8, 2020

Conversation

shoenig
Copy link
Contributor

@shoenig shoenig commented May 7, 2020

Make sure exposed checks work in e2e by setting an expose
check on the e2e connect test.

Make sure exposed checks work in e2e by setting an expose
check on the e2e connect test.
@shoenig shoenig requested review from tgross and nickethier May 7, 2020 21:02
Copy link
Member

@tgross tgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shoenig shoenig merged commit 320a757 into master May 8, 2020
@shoenig shoenig deleted the f-e2e-connect-use-expose-service-check branch May 8, 2020 15:00
@github-actions
Copy link

github-actions bot commented Jan 6, 2023

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants