Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

command/agent/csi_endpoint: explicit allocations #8669

Merged
merged 1 commit into from
Aug 13, 2020
Merged

command/agent/csi_endpoint: explicit allocations #8669

merged 1 commit into from
Aug 13, 2020

Conversation

langmartin
Copy link
Contributor

The API returns an Allocations collection containing nils, which causes the CLI to crash, part of #8665

@langmartin langmartin marked this pull request as ready for review August 13, 2020 19:41
@langmartin langmartin requested a review from tgross August 13, 2020 19:41
tgross
tgross approved these changes Aug 13, 2020
View reviewed changes
Copy link
Member

@tgross tgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

I can't make a comment on the line, but should structsCSISecretsToApi have both a length and capacity as well?

@langmartin
Copy link
Contributor Author

LGTM. 👍

I can't make a comment on the line, but should structsCSISecretsToApi have both a length and capacity as well?

No, it's an alias for map[string]string, so it only takes one argument

@langmartin langmartin merged commit 9ef3472 into master Aug 13, 2020
@langmartin langmartin deleted the b-csi-explicit-conversion branch August 13, 2020 19:48
@tgross tgross added this to the 0.12.4 milestone Aug 31, 2020
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tgross tgross tgross approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.12.4
Development

Successfully merging this pull request may close these issues.
2 participants
@langmartin @tgross