Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for enabling nested virtualization on intermediate instance #123

Merged
merged 1 commit into from
Jan 11, 2023
Merged

Support for enabling nested virtualization on intermediate instance #123

merged 1 commit into from
Jan 11, 2023

Conversation

atpons
Copy link
Contributor

@atpons atpons commented Oct 7, 2022

This PR allows us to launch a VM with nested virtualization enabled in an intermediate instance.

Closes #76

@atpons atpons requested a review from a team as a code owner October 7, 2022 03:23
@hashicorp-cla
Copy link

hashicorp-cla commented Oct 7, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

nywilken
nywilken approved these changes Jan 11, 2023
View reviewed changes
Copy link
Contributor

@nywilken nywilken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me. Thank you for the contribution.

@nywilken nywilken merged commit 5ba7178 into hashicorp:main Jan 11, 2023
@atpons atpons deleted the add-nested-virtualization-on-intermediate-instance branch January 12, 2023 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nywilken nywilken nywilken approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: enable_nested_virtualization on ephemeral instance
3 participants
@atpons @hashicorp-cla @nywilken