Fix docs extra disks #159
Merged
Fix docs extra disks #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nywilken
reviewed
May 2, 2023
| These can be defined using the [disk_attachment](#disk_attachment) block in the configuration. | ||
|
|
||
| Note that this is an array, and therefore in HCL2 can be defined as multiple blocks, each | ||
| one corresponding to a disk that will be attached to the instance you are booting. |
There was a problem hiding this comment.
Would it be helpful to add an example hcl2 block here?
There was a problem hiding this comment.
Done, I added one example with two disks defined in the template. Also to make sure it works well, I added an acceptance test for this case.
nywilken
approved these changes
May 2, 2023
lbajolet-hashicorp
force-pushed
the
fix_docs_extra_disks
branch
from
739d208 to
26c56d6
Compare
nywilken
approved these changes
May 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the
disk_attachmentblock was introduced to the builder, the docs weren't updated, making the feature essentially invisible for users.This commit adds a section to document those, and links for easier navigation in the docs.