Image architecture config #214
Conversation
|
|
There was a problem hiding this comment.
Hi @BrennenMM7,
Thanks for the PR, this will definitely be useful when released.
I left a couple of nits/suggestions on the code, please feel free to address/discuss those, and we can iterate on that.
I think this is the kind of feature that would benefit from acceptance tests, I'll see what I can do once we've stabilised the base code.
Obviously if you are willing to implement some acceptance test for this feature this would be very appreciated, and don't hesitate to reach out if you need a hand with those, I'll be happy to help.
|
Also, since you change the documentation for the |
BrennenMM7
force-pushed
the
image_architecture-config
branch
from
13dcffa to
d0e0d1f
Compare
There was a problem hiding this comment.
Hi @BrennenMM7,
Thanks for the reroll! I left a couple extra comments, especially regarding the case for the architecture, I'm not sure the APIs are case-sensitive for that enum, but it might be a good idea to make sure of that before merging (the acceptance tests may help to figure this one out though, I'll see if I can run them).
Other than that, this LGTM!
BrennenMM7
force-pushed
the
image_architecture-config
branch
from
2d51571 to
b57debf
Compare
BrennenMM7
force-pushed
the
image_architecture-config
branch
from
8815be4 to
aa283e8
Compare
|
@lbajolet-hashicorp Any chance of a green thumb? 🟢 |
There was a problem hiding this comment.
Hi @BrennenMM7,
Thanks for the reminder, and sorry I completely forgot to check back in after you re-uploaded the code, apologies for that!
I did a quick last review, the code looks good to me, I believe we can merge this today, thanks for being patient with us!
This PR is to add image_architecture as a config for the packer plugin. Currently this plugin only supports provisioning Image Types of X86_64 in GCP disabling the ability to create ARM based images.
image_architecture will allow consumers of this plugin to modify the disk type being provisioned by GCE to enable ARM based packer images in GCP.
Test and validation are included with this PR to ensure that image_architecture is set to X86_64 or ARM64, by default it will select X86_64 as its the most common. This field is also optional so leaving it blank or an empty value will serve backwards compatibility for current configs.