Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix zone or region detection regex #226

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

gac3k
Copy link
Contributor

@gac3k gac3k commented Jul 11, 2024

Currently, there are some zones (a very few but still) in GCP that are not conforming to that regular expression due to having two digits in the region name, before the zone suffix, i.e. europe-west10.

That PR is to allow both variations to be supported, otherwise a disk is not properly removed when an instance is being removed, and has to be deleted manually, as the script treats the value as region name not the zone.

@gac3k gac3k requested a review from a team as a code owner July 11, 2024 11:09
Copy link

hashicorp-cla-app bot commented Jul 11, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes


Dominik Gacek seems not to be a GitHub user.
You need a GitHub account to be able to sign the CLA.
If you have already a GitHub account, please add the email address used for this commit to your account.

Have you signed the CLA already but the status is still pending? Recheck it.

Copy link
Contributor

@lbajolet-hashicorp lbajolet-hashicorp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @gac3k,

Thanks for the PR, LGTM! Looks like there might be some CLA issue with the commits here, have you committed them with your Github account email?
Any chance you can double-check this? We unfortunately cannot accept the PR if the CLA's not signed for legal reasons.

@gac3k
Copy link
Contributor Author

gac3k commented Aug 27, 2024

@lbajolet-hashicorp I think there was a slight issue originally, but then I resign it, and now it looks fine the checks section (?)

Copy link
Contributor

@lbajolet-hashicorp lbajolet-hashicorp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @gac3k,

Thanks for the update, it does seem it's gone green so I'll merge this now!

@lbajolet-hashicorp lbajolet-hashicorp merged commit ae828dd into hashicorp:main Aug 27, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants