Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unneeded Sprintf #96

Merged
merged 2 commits into from
Jun 7, 2022
Merged

Remove unneeded Sprintf #96

merged 2 commits into from
Jun 7, 2022

Conversation

jason-h-35
Copy link
Contributor 

jasonhatton@localhost:~/code/packer-plugin-googlecompute$ golangci-lint run
builder/googlecompute/step_start_tunnel_test.go:78:5: S1025: the argument's underlying type is a slice of bytes, should use a simple conversion instead of fmt.Sprintf (gosimple)
        if fmt.Sprintf("%s", f) != expected {

This PR fixes this lint.

@jason-h-35 jason-h-35 requested a review from a team as a code owner June 7, 2022 20:14
@hashicorp-cla
Copy link

hashicorp-cla commented Jun 7, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

nywilken
nywilken approved these changes Jun 7, 2022
View reviewed changes
Copy link
Contributor

@nywilken nywilken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for the fix.

@nywilken nywilken merged commit ac32fc8 into hashicorp:main Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nywilken nywilken nywilken approved these changes

Assignees
No one assigned
Labels
tech-debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jason-h-35 @hashicorp-cla @nywilken