Add SSHKeygen step from SDK #165
Conversation
There was a problem hiding this comment.
Hi @LIV2,
Sorry for the delay before review, the code looks straightforward enough, and I really like your example, this is really nice.
Thanks for that feature, I left a small question on the example itself, but overall this looks good to me, we can merge this ASAP.
There's just the documentation to generate, may I ask you to run make generate on the project, and commit the resulting files?
Let me know if this is problematic, I can give you a hand on that.
|
|
||
| ```json | ||
| "boot_command": [ | ||
| "<up><wait><tab> text ks=http://{{ .HTTPIP }}:{{ .HTTPPort }}/ks.cfg PACKER_USER={{ user `username` }} PACKER_AUTHORIZED_KEY={{ .SSHPublicKey | urlquery }}<enter>" |
There was a problem hiding this comment.
Out of curiosity, why the urlquery for the public key? If this is raw base64 encoded data, there shouldn't be anything problematic here, is there?
Or maybe spaces, is that the reason why?
If so, maybe escaping the payload would be enough?
Don't get me wrong it's an example so it's fine if it's not perfect/robust in every case, the current implementation should work also.
There was a problem hiding this comment.
Probably the spaces, this was just copied from the virtualbox-iso documentation
I will run make generate and commit the files
|
Many thanks for the quick reroll @LIV2, much appreciated! |
This change adds the SSHKeyGen step from the SDK.
When the communicator configured is SSH, this step will generate a temporary ssh keypair when there is no ssh password and no ssh key configured.
Also included is the ability to use the SSHPublicKey variable inside the boot command.
This feature is present in the Virtualbox and VMware builders and I thought it would be good to have it here too.