Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StepCreateCD: Clean up temporary directory and add more robust tests #62

Merged
merged 6 commits into from
May 12, 2021
Merged

StepCreateCD: Clean up temporary directory and add more robust tests #62

merged 6 commits into from
May 12, 2021

Conversation

saleemrashid
Copy link
Contributor

This adds more robust tests that check the actual filenames and contents in the temporary directory, as well as removing the temporary directory in the step cleanup. This also tests adding folders, which wasn't previously being tested.

The motivation for checking the content is to allow tests for #61 that test how cd_files and cd_content interact (e.g. that cd_content correctly takes precedence over cd_files).

@saleemrashid saleemrashid requested a review from a team as a code owner April 29, 2021 20:28
Copy link
Contributor

@azr azr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello there, thanks for opening, this LGTM and you simply need to fix some linting issues: https://app.circleci.com/pipelines/github/hashicorp/packer-plugin-sdk/372/workflows/dd870b66-cf48-4d09-ba04-abdc676ba893/jobs/3054

Thanks for your time 🙂

@azr
Copy link
Contributor

azr commented May 12, 2021

Fixed the linting issues !

@azr azr merged commit ac048b4 into hashicorp:main May 12, 2021
@saleemrashid
Copy link
Contributor Author

Thank you, and sorry I hadn't had a chance to fix them 🙏

@azr
Copy link
Contributor

azr commented May 18, 2021

👍🏼 🙂 all good !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants