-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
StepCreateCD: Clean up temporary directory and add more robust tests #62
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello there, thanks for opening, this LGTM and you simply need to fix some linting issues: https://app.circleci.com/pipelines/github/hashicorp/packer-plugin-sdk/372/workflows/dd870b66-cf48-4d09-ba04-abdc676ba893/jobs/3054
Thanks for your time 🙂
fix linting issues
fix linting issues
Fixed the linting issues ! |
Thank you, and sorry I hadn't had a chance to fix them 🙏 |
👍🏼 🙂 all good ! |
This adds more robust tests that check the actual filenames and contents in the temporary directory, as well as removing the temporary directory in the step cleanup. This also tests adding folders, which wasn't previously being tested.
The motivation for checking the content is to allow tests for #61 that test how
cd_files
andcd_content
interact (e.g. thatcd_content
correctly takes precedence overcd_files
).