builder/vmware-esx: Ignore localhost for VNC lookup and document VNC requirements [GH-1480] #1505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds logic to ESXi driver VNC Address function to ignore listen addresses that bind to localhost (127.0.0.1), this allows certain default ports to be available on ESXi for VNC connections
jasonberanek
added a commit
that referenced
this pull request
Sep 17, 2014
builder/vmware-esx: Ignore localhost for VNC lookup and document VNC requirements [GH-1480]
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request to address #1480, both by ignoring results from ESXi where it listens on localhost, and by adding a statement that firewall rules may need to be modified to support VNC.