Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set status to left if memberlist did it #601

Merged
merged 2 commits into from
May 4, 2020
Merged

Set status to left if memberlist did it #601

merged 2 commits into from
May 4, 2020

Conversation

hanshasselberg
Copy link
Member

needs: hashicorp/memberlist#223. This is part of something bigger too!

@hanshasselberg hanshasselberg mentioned this pull request Apr 30, 2020
Merged
mkeeler
mkeeler requested changes May 1, 2020
View reviewed changes
Copy link
Member

@mkeeler mkeeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need to update the go.mod to point to the right version of memberlist too. Otherwise this looks good.

mkeeler
mkeeler approved these changes May 1, 2020
View reviewed changes
Copy link
Member

@mkeeler mkeeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realized when reviewing the consul PR that you couldn't have done the module updates yet because we need to cut a memberlist release. I am going to approve and assume you will do those others, so as not to block you getting these merged early on Monday.

@hanshasselberg hanshasselberg merged commit de293af into master May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkeeler mkeeler mkeeler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hanshasselberg @mkeeler