Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mitigate against token replication lag #102

Merged
merged 3 commits into from
May 2, 2022

Conversation

pglass
Copy link

@pglass pglass commented Apr 28, 2022

Changes proposed in this PR:

Copy the approach from hashicorp/consul-k8s#887 for dealing with inherent token replication lag.

See: hashicorp/consul-ecs#79

How I've tested this PR:

Acceptance tests

How I expect reviewers to test this PR:

👀

Checklist:

  • Tests added
  • CHANGELOG entry added n/a

@pglass pglass requested a review from cthain April 28, 2022 18:52
@pglass pglass force-pushed the pglass/mitigate-token-replication branch from 5d73386 to 0d3e19c Compare April 28, 2022 18:53
Copy link
Contributor

@cthain cthain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good Paul. I left a couple of nitpicks.

@pglass pglass force-pushed the pglass/mitigate-token-replication branch from 0d3e19c to d821b2c Compare April 28, 2022 21:34
Base automatically changed from pglass/iam-auth-mesh-task to main May 2, 2022 14:38
@pglass pglass force-pushed the pglass/mitigate-token-replication branch from d821b2c to 4f98aec Compare May 2, 2022 14:41
@pglass pglass merged commit 4627171 into main May 2, 2022
@pglass pglass deleted the pglass/mitigate-token-replication branch May 2, 2022 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants