update variable min/max to single variable

[tlinkin]

Given the repeatability of the cluster size changing to a single value to also maintain coherence with the consul module seems like a good idea.

[brikis98]

Thanks for the PR! I agree this is probably the right change.

How did you test this? As far as I can see, the root main.tf has not been updated to use this new input variable...

[tlinkin]

We are using the module from git::https://github.com/tlinkin/terraform-aws-nomad.git//modules/nomad-cluster?ref=tf12 in Terraform Enterprise 0.12.3 and our environment is stable.

I will have a look at main.tf so the unit test work properly after merging.

[brikis98]

Thanks! Kicking off tests now.

[brikis98]

Re-running the tests

[brikis98]

This time, two tests failed again:

TestNomadConsulClusterSeparateAmazonLinuxAmi 2019-07-11T15:15:27Z command.go:158: �[31m
TestNomadConsulClusterSeparateAmazonLinuxAmi 2019-07-11T15:15:27Z command.go:158: �[1m�[31mError: �[0m�[0m�[1mUnsupported argument�[0m
TestNomadConsulClusterSeparateAmazonLinuxAmi 2019-07-11T15:15:27Z command.go:158: 
TestNomadConsulClusterSeparateAmazonLinuxAmi 2019-07-11T15:15:27Z command.go:158: �[0m  on main.tf line 177, in module "nomad_clients":
TestNomadConsulClusterSeparateAmazonLinuxAmi 2019-07-11T15:15:27Z command.go:158:  177:   �[4mmin_size�[0m         = var.num_nomad_clients
TestNomadConsulClusterSeparateAmazonLinuxAmi 2019-07-11T15:15:27Z command.go:158: �[0m
TestNomadConsulClusterSeparateAmazonLinuxAmi 2019-07-11T15:15:27Z command.go:158: An argument named "min_size" is not expected here.
TestNomadConsulClusterSeparateAmazonLinuxAmi 2019-07-11T15:15:27Z command.go:158: �[0m�[0m
TestNomadConsulClusterSeparateAmazonLinuxAmi 2019-07-11T15:15:27Z command.go:158: �[31m
TestNomadConsulClusterSeparateAmazonLinuxAmi 2019-07-11T15:15:27Z command.go:158: �[1m�[31mError: �[0m�[0m�[1mUnsupported argument�[0m
TestNomadConsulClusterSeparateAmazonLinuxAmi 2019-07-11T15:15:27Z command.go:158: 
TestNomadConsulClusterSeparateAmazonLinuxAmi 2019-07-11T15:15:27Z command.go:158: �[0m  on main.tf line 178, in module "nomad_clients":
TestNomadConsulClusterSeparateAmazonLinuxAmi 2019-07-11T15:15:27Z command.go:158:  178:   �[4mmax_size�[0m         = var.num_nomad_clients
TestNomadConsulClusterSeparateAmazonLinuxAmi 2019-07-11T15:15:27Z command.go:158: �[0m
TestNomadConsulClusterSeparateAmazonLinuxAmi 2019-07-11T15:15:27Z command.go:158: An argument named "max_size" is not expected here.
TestNomadConsulClusterSeparateAmazonLinuxAmi 2019-07-11T15:15:27Z command.go:158: �[0m�[0m
TestNomadConsulClusterSeparateAmazonLinuxAmi 2019-07-11T15:15:27Z command.go:158: �[31m
TestNomadConsulClusterSeparateAmazonLinuxAmi 2019-07-11T15:15:27Z command.go:158: �[1m�[31mError: �[0m�[0m�[1mUnsupported argument�[0m
TestNomadConsulClusterSeparateAmazonLinuxAmi 2019-07-11T15:15:27Z command.go:158: 
TestNomadConsulClusterSeparateAmazonLinuxAmi 2019-07-11T15:15:27Z command.go:158: �[0m  on main.tf line 179, in module "nomad_clients":
TestNomadConsulClusterSeparateAmazonLinuxAmi 2019-07-11T15:15:27Z command.go:158:  179:   �[4mdesired_capacity�[0m = var.num_nomad_clients
TestNomadConsulClusterSeparateAmazonLinuxAmi 2019-07-11T15:15:27Z command.go:158: �[0m
TestNomadConsulClusterSeparateAmazonLinuxAmi 2019-07-11T15:15:27Z command.go:158: An argument named "desired_capacity" is not expected here.
TestNomadConsulClusterSeparateAmazonLinuxAmi 2019-07-11T15:15:27Z command.go:158: �[0m�[0m

Looks like you forgot to update some examples? Please test more thoroughly.

[tlinkin]

We never used the default example, but our module is running in production quite successfully. It is rather hard to test as I do not have any access to the output of your CircleCI and if all contributors are expected to spin up the test example scripts on their own and all the testing this would lead to rather stale development in my opinion.

Anyway the client example is exactly the same as the server example, which passes the test and runs in our production environment. I cannot see where the error is, if you can please point me in the right direction and I will fix it.

[tlinkin]

Anyway I found the error in the separate example. Fixed it.

[brikis98]

It is rather hard to test as I do not have any access to the output of your CircleCI and if all contributors are expected to spin up the test example scripts on their own and all the testing this would lead to rather stale development in my opinion.

The tests are automated. Docs are here: https://github.com/hashicorp/terraform-aws-nomad/tree/master/test

Anyway I found the error in the separate example. Fixed it.

Thanks. I'll kick off the tests again shortly.

[brikis98]

TestNomadConsulClusterSeparateAmazonLinuxAmi 2019-07-18T13:35:43Z command.go:158: �[1m�[31mError: �[0m�[0m�[1mReference to undeclared input variable�[0m
TestNomadConsulClusterSeparateAmazonLinuxAmi 2019-07-18T13:35:43Z command.go:158: 
TestNomadConsulClusterSeparateAmazonLinuxAmi 2019-07-18T13:35:43Z command.go:158: �[0m  on main.tf line 168, in module "nomad_clients":
TestNomadConsulClusterSeparateAmazonLinuxAmi 2019-07-18T13:35:43Z command.go:158:  168:   cluster_size  = �[4mvar.num_clients�[0m
TestNomadConsulClusterSeparateAmazonLinuxAmi 2019-07-18T13:35:43Z command.go:158: �[0m
TestNomadConsulClusterSeparateAmazonLinuxAmi 2019-07-18T13:35:43Z command.go:158: An input variable with the name "num_clients" has not been declared. This
TestNomadConsulClusterSeparateAmazonLinuxAmi 2019-07-18T13:35:43Z command.go:158: variable can be declared with a variable "num_clients" {} block.
TestNomadConsulClusterSeparateAmazonLinuxAmi 2019-07-18T13:35:43Z command.go:158: �[0m�[0m
TestNomadConsulClusterSeparateAmazonLinuxAmi 2019-07-18T13:35:43Z retry.go:80: Returning due to fatal error: FatalError{Underlying: exit status 1}
--

[hashicorp-cla]

All committers have signed the CLA.