Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add in CA plumbing for custom certificates #7

Merged
merged 4 commits into from
Sep 30, 2019
Merged

Conversation

rogeruiz
Copy link
Contributor

This is work that was done originally in hashicorp/terraform-google-terraform-enterprise#3 and ported over to this repo. The largest difference between these two implementations is that this TF uses cloud-config and the other didn't. But everything else is pretty much the same.

@rogeruiz rogeruiz requested a review from a team September 17, 2019 18:59
Copy link
Contributor

@erindatkinson erindatkinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just the one update, otherwise it looks good!

templates/cloud-config-secondary.yaml Show resolved Hide resolved
Copy link
Contributor

@erindatkinson erindatkinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌈

@rogeruiz rogeruiz merged commit e794e17 into master Sep 30, 2019
@rogeruiz rogeruiz deleted the f-plumb-customer-ca branch September 30, 2019 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants