Prefill Required Attributes

This adds a new experimental setting for prefilling required attributes as blocks are completed from intellisense. For example, completing a resource provider will fill in the required attributes automatically.
hashicorp · Sep 29, 2021 · 4ee3778 · 4ee3778
1 parent 8840e7b
commit 4ee3778
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 1 deletion.
diff --git a/internal/langserver/handlers/complete.go b/internal/langserver/handlers/complete.go
@@ -47,6 +47,13 @@ func (h *logHandler) TextDocumentComplete(ctx context.Context, params lsp.Comple
 	}
 	d.SetSchema(schema)
 
+	expFeatures, err := lsctx.ExperimentalFeatures(ctx)
+	if err != nil {
+		d.PrefillRequiredAttributes = false
+	}
+
+	d.PrefillRequiredAttributes = expFeatures.PrefillRequiredAttributes
+
 	fPos, err := ilsp.FilePositionFromDocumentPosition(params.TextDocumentPositionParams, file)
 	if err != nil {
 		return list, err

diff --git a/internal/langserver/handlers/service.go b/internal/langserver/handlers/service.go
@@ -217,6 +217,7 @@ func (svc *service) Assigner() (jrpc2.Assigner, error) {
 			ctx = lsctx.WithDocumentStorage(ctx, svc.fs)
 			ctx = lsctx.WithClientCapabilities(ctx, cc)
 			ctx = lsctx.WithModuleFinder(ctx, svc.modMgr)
+			ctx = lsctx.WithExperimentalFeatures(ctx, &expFeatures)
 
 			return handle(ctx, req, lh.TextDocumentComplete)
 		},

diff --git a/internal/settings/settings.go b/internal/settings/settings.go
@@ -9,7 +9,8 @@ import (
 )
 
 type ExperimentalFeatures struct {
-	ValidateOnSave bool `mapstructure:"validateOnSave"`
+	ValidateOnSave            bool `mapstructure:"validateOnSave"`
+	PrefillRequiredAttributes bool `mapstructure:"prefillRequiredAttributes"`
 }
 
 type Options struct {