Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support templated paths for cpuprofile & memprofile #224

Closed
radeksimko opened this issue Jul 10, 2020 · 1 comment · Fixed by #501
Closed

Support templated paths for cpuprofile & memprofile #224

radeksimko opened this issue Jul 10, 2020 · 1 comment · Fixed by #501
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@radeksimko
Copy link
Member

Current Version

0.4.1

Use-cases

#223 introduces new troubleshooting flags, which - unlike the other two (log-file & tf-log-file) don't support templating. As the profiling should be something users need to enable only rarely the value of templating is much lower, but it would still be useful to be able to see things in context and correlate log files with profiles e.g. by PIDs.

Attempted Solutions

Run only one instance of the server, or try to match log manually (error prone).

Proposal

Decouple template processing into its own package and support the same variables/functions as we support for the logging flags.

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant