Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce CPU & memory profiling #223

Merged
merged 2 commits into from
Jul 10, 2020
Merged

Introduce CPU & memory profiling #223

merged 2 commits into from
Jul 10, 2020

Conversation

radeksimko
Copy link
Member

@radeksimko radeksimko commented Jul 10, 2020 •
edited
Loading

This aims to help with debugging #217

@radeksimko radeksimko added the enhancement New feature or request label Jul 10, 2020
@radeksimko radeksimko requested a review from a team July 10, 2020 08:12
@radeksimko radeksimko marked this pull request as ready for review July 10, 2020 08:48
This was referenced Jul 10, 2020
Closed
Closed
@radeksimko radeksimko added this to the v0.5.0 milestone Jul 10, 2020
appilon
appilon approved these changes Jul 10, 2020
View reviewed changes
Copy link
Contributor

@appilon appilon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall approve but I did have some questions

commands/serve_command.go Outdated Show resolved Hide resolved
commands/serve_command.go Show resolved Hide resolved
@radeksimko radeksimko merged commit 740c30d into master Jul 10, 2020
@radeksimko radeksimko deleted the f-profiling branch July 10, 2020 17:41
@ghost
Copy link

ghost commented Aug 9, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the context necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Aug 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@appilon appilon appilon approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@radeksimko @appilon