Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

settings: break down terraform CLI related settings #1011

Merged
merged 2 commits into from
Jul 26, 2022
Merged

settings: break down terraform CLI related settings #1011

merged 2 commits into from
Jul 26, 2022

Conversation

radeksimko
Copy link
Member

@radeksimko radeksimko commented Jul 22, 2022 •
edited
Loading

Depends on #1010

This aligns Terraform CLI related settings with the recently documented principles https://github.com/hashicorp/terraform-ls/blob/main/docs/language-clients.md#configuration

@radeksimko radeksimko added enhancement New feature or request technical-debt labels Jul 22, 2022
@radeksimko radeksimko added this to the v0.29.0 milestone Jul 22, 2022
@radeksimko radeksimko self-assigned this Jul 22, 2022
@radeksimko radeksimko force-pushed the f-break-down-tf-opts branch from 7a3ae14 to 0dcd4be Compare July 22, 2022 11:00
@radeksimko radeksimko mentioned this pull request Jul 22, 2022
Merged
@radeksimko radeksimko force-pushed the f-break-down-tf-opts branch from 0dcd4be to ddabdde Compare July 22, 2022 13:12
@radeksimko radeksimko marked this pull request as ready for review July 22, 2022 13:18
@radeksimko radeksimko requested a review from a team as a code owner July 22, 2022 13:18
dbanck
dbanck approved these changes Jul 25, 2022
View reviewed changes
Copy link
Member

@dbanck dbanck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I was expecting changes to settings_test.go, but there are no test for this.

@radeksimko
Copy link
Member Author

I was expecting changes to settings_test.go, but there are no test for this.

I can't think of a way of testing the settings in a useful and non-fragile way, i.e. that we don't just end up testing the underlying mapstructure decoding logic, but I'm open to ideas.

@dbanck
Copy link
Member

dbanck commented Jul 25, 2022 •
edited
Loading

Mhm, I guess the only worth testing might be the validation of TerraformExecPath Terraform.Path?

@radeksimko radeksimko merged commit 496e19d into main Jul 26, 2022
@radeksimko radeksimko deleted the f-break-down-tf-opts branch July 26, 2022 20:14
@radeksimko radeksimko mentioned this pull request Jul 27, 2022
Merged
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dbanck dbanck dbanck approved these changes

@jpogran jpogran jpogran approved these changes

Assignees

@radeksimko radeksimko

Labels
enhancement New feature or request technical-debt
Projects
None yet
Milestone
v0.29.0
Development

Successfully merging this pull request may close these issues.
3 participants
@radeksimko @dbanck @jpogran