Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't query the TF registry for module sources starting with "." #1062

Merged
merged 4 commits into from
Sep 5, 2022

Conversation

dbanck
Copy link
Member

@dbanck dbanck commented Sep 5, 2022

This PR updates the check for local module prefixes from ../ to . to stop sending search requests for . and .. to the TF registry.

Closes #1053

Relative paths in the go.work file are likely machine specific and
won't work on other systems.
@dbanck dbanck added the enhancement New feature or request label Sep 5, 2022
@dbanck dbanck self-assigned this Sep 5, 2022
@dbanck dbanck requested a review from a team as a code owner September 5, 2022 08:57
As of Go 1.16, this value is simply io.Discard.
@dbanck dbanck merged commit 055eaf9 into main Sep 5, 2022
@dbanck dbanck deleted the f-improve-algolia-ignore branch September 5, 2022 09:35
@radeksimko radeksimko added this to the v0.29.2 milestone Sep 12, 2022
@github-actions
Copy link

This functionality has been released in v0.29.2 of the language server.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filter module source registry completion requests
2 participants