-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for function signature help #1077
Conversation
682e224
to
b58ec93
Compare
c53e993
to
b6acd5d
Compare
2bb46db
to
d1bdf99
Compare
d1bdf99
to
20509ec
Compare
6bc553f
to
b141022
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall, works great 🥇 👍🏻
I left only very minor questions and comments in-line but they're not really blocking.
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
This PR enables signature help for function signatures.
To make this work, we first add the function signatures from terraform-schema (introduced in hashicorp/terraform-schema#145) to the
PathContext
. This work is also required to enable completion, hover, etc. for functions later on.We then add a new handler for the
textDocument/signatureHelp
LSP method.UX
Nested function calls with variadic parameters
Functions without any arguments
No signature help, if passing too many arguments
Multiline function calls
SignatureAtPos
hcl-lang#135