Introduce go-to-variable from tfvars files
#727
Conversation
There was a problem hiding this comment.
Just one note about the test, but LGTM overall!
I'm however currently investigating a bug which may result in a patch release and so if you can avoid merging this until I'm done investigating that would be great!
| @@ -64,6 +64,11 @@ func TestModuleLoader_referenceCollection(t *testing.T) { | |||
| if err != nil { | |||
| t.Fatal(err) | |||
| } | |||
| varsOriginsOp := NewModuleOperation(modPath, op.OpTypeDecodeVarsReferences) | |||
| err = ml.EnqueueModuleOp(varsOriginsOp) | |||
There was a problem hiding this comment.
I think this part of the test isn't going to be very useful unless we also add tfvars file(s) to the test module in testdata/single-root-no-modules. It may be fine just to leave this test as it was though. The logic seems well tested in isolation.
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Closes #618
Depends on:
tfvarsw/ variables terraform-schema#84UX Implications
Go to definition
Go to reference(s)