Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: add golangci linting + fixed deprecations #212

Merged
merged 8 commits into from
Jan 25, 2023
Merged

ci: add golangci linting + fixed deprecations #212

merged 8 commits into from
Jan 25, 2023

Conversation

austinvalle
Copy link
Member

@austinvalle austinvalle requested a review from a team as a code owner January 24, 2023 18:47
bendbennett
bendbennett previously approved these changes Jan 25, 2023
View reviewed changes
Copy link
Contributor

@bendbennett bendbennett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@austinvalle
Copy link
Member Author

@bendbennett

I added a quick line ending fix to the action so windows won't break gofmt 🙄
Original failure: https://github.com/hashicorp/terraform-plugin-docs/actions/runs/4006540731/jobs/6878195361#step:4:28

golangci/golangci-lint#580

@bendbennett
Copy link
Contributor

@bendbennett

I added a quick line ending fix to the action so windows won't break gofmt 🙄 Original failure: https://github.com/hashicorp/terraform-plugin-docs/actions/runs/4006540731/jobs/6878195361#step:4:28

golangci/golangci-lint#580

Nice 👍

@austinvalle austinvalle merged commit 73956a6 into main Jan 25, 2023
@austinvalle austinvalle deleted the av/lint branch January 25, 2023 14:28
@austinvalle austinvalle mentioned this pull request Feb 21, 2023
Closed
@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bendbennett bendbennett bendbennett approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@austinvalle @bendbennett