Removed ListNestedAttributesOptions, SetNestedAttributesOptions and MapNestedAttributesOptions types, as they were empty (no fields) and unused
#349
Conversation
…nd `MapNestedAttributesOptions` types, as they were empty (no fields) and unused. Because of this, `ListNestedAttributes`, `SetNestedAttributes` and `MapNestedAttributes` functions lost the second argument `opts`, as it was unused.
| @@ -73,7 +73,7 @@ type NestedAttributes interface { | |||
| type nestedAttributes map[string]Attribute | |||
|
|
|||
| func (n nestedAttributes) GetAttributes() map[string]Attribute { | |||
| return map[string]Attribute(n) | |||
| return n | |||
There was a problem hiding this comment.
Goland made me do it ®
| @@ -111,7 +111,7 @@ func (n nestedAttributes) AttributeType() attr.Type { | |||
| // configuration. | |||
| func SingleNestedAttributes(attributes map[string]Attribute) NestedAttributes { | |||
| return singleNestedAttributes{ | |||
| nestedAttributes(attributes), | |||
| attributes, | |||
There was a problem hiding this comment.
Goland made me do it ®
docs/design/blocks.md
Outdated
| @@ -522,7 +522,7 @@ func (t exampleThingResourceType) GetSchema(_ context.Context) (Schema, diag.Dia | |||
| Required: true, | |||
| Type: types.StringType, | |||
| }, | |||
| }, ListNestedAttributesOptions{}), | |||
There was a problem hiding this comment.
I think we should keep the design documentation with the original context/decision here and below.
There was a problem hiding this comment.
I'm ok with it, even though I can foresee someone coming here, reading the doc, and getting confused.
But we already discussed this, so 👍
bflad
added
enhancement
This reverts commit d0b3fec.
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
No description provided.