Binary testing: omit test cleanup when state is empty #356
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #347
The legacy test framework does not attempt a post-test destroy step when there is no state: https://github.com/hashicorp/terraform-plugin-sdk/blob/master/helper/resource/testing.go#L701
This was missed out of the new framework, with the consequence that successful tests that do not create resources would error during cleanup.
We add this check back, in new binary testing style - the nuance here being that our state may well contain modules but no resources.
Again, I'll raise a separate PR to the
version2
branch after review.