helper/schema: Introduce ResourceData GetResourceId and SetResourceId receiver methods and only passthrough id attribute state if present #542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… receiver methods and only passthrough id attribute state if present Reference: hashicorp#541 This allows resources to decouple from the implicit `id` attribute by only working with the underlying resource identifier (`InstanceState.ID`). Any `id` attribute handling is omitted from these new receiver methods. For reference, the existing `Id()` receiver method always read the `id` attribute as a fallback if the resource identifier was missing and `SetId()` always set the `id` attribute to match the resource identifier. Also part of this support, the `id` attribute is no longer always "promoted" using the resource identifier if the attribute is missing when retrieving the state, however it is always passed through if present in the previous or new state. Existing logic using `SetId()` and the existing import functionality are unaffected as they continue to set the `id` attribute.
|
Going to close this out -- I don't think we'll want to do this in this version of the framework and its not worth keeping it as an open pull request. |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #541
Implements proposal 1 from the issue. This goes through the process of deprecating the existing functionality to support potential longer term goals with the SDK (treating the
idattribute` like all others), but if that is not warranted happy to change up the implementation here.This allows resources to decouple from the implicit
idattribute by only working with the underlying resource identifier (InstanceState.ID). Anyidattribute handling is omitted from these new receiver methods. For reference, the existingId()receiver method always read theidattribute as a fallback if the resource identifier was missing andSetId()always set theidattribute to match the resource identifier.Also part of this support, the
idattribute is no longer always "promoted" using the resource identifier if the attribute is missing when retrieving the state, however it is always passed through if present in the previous or new state. Existing logic usingSetId()and the existing import functionality are unaffected as they continue to set theidattribute.Current changes:
Potential major version changes in the future relating to this: