Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Enable acceptance testing #224

Merged
merged 3 commits into from
Nov 27, 2023
Merged

ci: Enable acceptance testing #224

merged 3 commits into from
Nov 27, 2023

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Nov 22, 2023

This change adds Terraform version matrix testing to the Go code testing workflow and ensures that acceptance testing is enabled, since there are many tests that require the environment variable to run. Unsetting TF_ACC_TERRAFORM_PATH is necessary for locally running the tests on other Terraform versions.

This change adds Terraform version matrix testing to the Go code testing workflow and ensures that acceptance testing is enabled, since there are many tests that require the environment variable to run.
@bflad bflad requested a review from a team as a code owner November 22, 2023 18:34
Copy link
Contributor

@bendbennett bendbennett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@bflad bflad added this to the v1.6.0 milestone Nov 27, 2023
@bflad bflad merged commit 6f2d420 into main Nov 27, 2023
25 checks passed
@bflad bflad deleted the bflad/test-all-tf-versions branch November 27, 2023 18:06
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants