Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update go-version to support darwin/arm64 builds #101

Merged
merged 5 commits into from
May 10, 2021
Merged

Conversation

aareet
Copy link
Contributor

@aareet aareet commented May 3, 2021

Description

Updates the go-version to enable building for darwin/arm64

References

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

@ghost ghost added the size/XS label May 3, 2021
@bflad
Copy link
Contributor

bflad commented May 3, 2021

I think we may need to double check that go-version without the leading period in the file name is supported by goenv and the TeamCity scripts -- most other providers are using .go-version. This line would also need adjustment in that case:

It may also be worth updating some other places as well:

  • .travis.yml
  • README.md
  • go.mod (also running go mod tidy && go mod vendor)

@aareet aareet marked this pull request as draft May 3, 2021 15:27
@koikonom koikonom marked this pull request as ready for review May 10, 2021 09:02
@koikonom koikonom force-pushed the aareet-darwin-arm64 branch from d78a095 to fc9c2e6 Compare May 10, 2021 09:10
@ghost ghost added size/S and removed size/XS labels May 10, 2021
@koikonom
Copy link
Contributor

Rebased and removed travis.yml

@koikonom koikonom merged commit 316e49f into main May 10, 2021
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants