Skip to content

Commit

Permalink
resource/aws_globalaccelerator_accelerator: Address #7002 PR feedback
Browse files Browse the repository at this point in the history
Changes:

* Remove `Computed: true` from `attributes` attribute
* Fix `TestAccAwsGlobalAcceleratorAccelerator_update` check

Output from acceptance testing:

```
--- PASS: TestAccAwsGlobalAcceleratorAccelerator_basic (55.12s)
--- PASS: TestAccAwsGlobalAcceleratorAccelerator_attributes (69.74s)
--- PASS: TestAccAwsGlobalAcceleratorAccelerator_update (89.72s)
```
  • Loading branch information
bflad committed Jan 15, 2019
1 parent ddd268e commit 27b1102
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 2 deletions.
1 change: 0 additions & 1 deletion aws/resource_aws_globalaccelerator_accelerator.go
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,6 @@ func resourceAwsGlobalAcceleratorAccelerator() *schema.Resource {
"attributes": {
Type: schema.TypeList,
Optional: true,
Computed: true,
MaxItems: 1,
DiffSuppressFunc: func(k, old, new string, d *schema.ResourceData) bool {
if old == "1" && new == "0" {
Expand Down
2 changes: 1 addition & 1 deletion aws/resource_aws_globalaccelerator_accelerator_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ func TestAccAwsGlobalAcceleratorAccelerator_update(t *testing.T) {
Config: testAccGlobalAcceleratorAccelerator_basic(rName, true),
Check: resource.ComposeTestCheckFunc(
testAccCheckGlobalAcceleratorAcceleratorExists(resourceName),
resource.TestCheckResourceAttr(resourceName, "name", newName),
resource.TestCheckResourceAttr(resourceName, "name", rName),
resource.TestCheckResourceAttr(resourceName, "enabled", "true"),
),
},
Expand Down

0 comments on commit 27b1102

Please sign in to comment.