r/aws_appflow_flow: Don't send empty 'task' during update -- hashicor…

…p/terraform-plugin-sdk#588.
hashicorp · Nov 17, 2023 · ae3ed0a · ae3ed0a
1 parent e766888
commit ae3ed0a
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 3 deletions.
diff --git a/.changelog/34456.txt b/.changelog/34456.txt
@@ -1,3 +1,7 @@
 ```release-note:bug
 resource/aws_appflow_flow: Fix `interface conversion: interface {} is nil, not map[string]interface {}` panic 
+```
+
+```release-note:bug
+resource/aws_appflow_flow: Fix `InvalidParameter: 2 validation error(s) found` error when `task` is updated
 ```
diff --git a/internal/service/appflow/flow.go b/internal/service/appflow/flow.go
@@ -2416,6 +2416,9 @@ func expandTask(tfMap map[string]interface{}) *types.Task {
 
 	if v, ok := tfMap["task_type"].(string); ok && v != "" {
 		a.TaskType = types.TaskType(v)
+	} else {
+		// https://github.com/hashicorp/terraform-provider-aws/issues/28237.
+		return nil
 	}
 
 	return a

diff --git a/internal/service/appflow/flow_test.go b/internal/service/appflow/flow_test.go
@@ -231,7 +231,7 @@ func TestAccAppFlowFlow_taskUpdate(t *testing.T) {
 				),
 			},
 			{
-				Config: testAccFlowConfig_multipleTasks(rSourceName, rDestinationName, rFlowName, "anotherField"),
+				Config: testAccFlowConfig_multipleTasks(rSourceName, rDestinationName, rFlowName, "anotherTestField"),
 				Check: resource.ComposeTestCheckFunc(
 					testAccCheckFlowExists(ctx, resourceName, &flowOutput),
 					resource.TestCheckResourceAttr(resourceName, "task.#", "3"),
@@ -252,9 +252,9 @@ func TestAccAppFlowFlow_taskUpdate(t *testing.T) {
 						"task_type":                             "Map",
 					}),
 					resource.TestCheckTypeSetElemNestedAttrs(resourceName, "task.*", map[string]string{
-						"destination_field":                     "anotherField",
+						"destination_field":                     "anotherTestField",
 						"source_fields.#":                       "1",
-						"source_fields.0":                       "anotherField",
+						"source_fields.0":                       "anotherTestField",
 						"task_properties.%":                     "2",
 						"task_properties.DESTINATION_DATA_TYPE": "id",
 						"task_properties.SOURCE_DATA_TYPE":      "id",