Skip to content

Commit

Permalink
service/eks: Finish up public_access_cidrs implementation
Browse files Browse the repository at this point in the history
Reference: #11397
Reference: #11442

Output from acceptance testing:

```
--- PASS: TestAccAWSEksCluster_basic (1221.74s)
--- PASS: TestAccAWSEksCluster_Tags (1277.77s)
--- PASS: TestAccAWSEksClusterDataSource_basic (1277.90s)
--- PASS: TestAccAWSEksCluster_Logging (1278.03s)
--- PASS: TestAccAWSEksCluster_VpcConfig_SecurityGroupIds (1295.59s)
--- PASS: TestAccAWSEksCluster_VpcConfig_PublicAccessCidrs (1422.58s)
--- PASS: TestAccAWSEksCluster_VpcConfig_EndpointPublicAccess (1905.76s)
--- PASS: TestAccAWSEksCluster_VpcConfig_EndpointPrivateAccess (2322.50s)
--- PASS: TestAccAWSEksCluster_Version (2450.83s)
```
  • Loading branch information
bflad committed Jan 9, 2020
1 parent 32384f8 commit ce59253
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 2 deletions.
2 changes: 1 addition & 1 deletion aws/data_source_aws_eks_cluster.go
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ func dataSourceAwsEksCluster() *schema.Resource {
},
"public_access_cidrs": {
Type: schema.TypeSet,
Optional: true,
Computed: true,
Elem: &schema.Schema{Type: schema.TypeString},
},
"vpc_id": {
Expand Down
1 change: 1 addition & 0 deletions aws/resource_aws_eks_cluster.go
Original file line number Diff line number Diff line change
Expand Up @@ -148,6 +148,7 @@ func resourceAwsEksCluster() *schema.Resource {
"public_access_cidrs": {
Type: schema.TypeSet,
Optional: true,
Computed: true,
Elem: &schema.Schema{
Type: schema.TypeString,
ValidateFunc: validateCIDRNetworkAddress,
Expand Down
2 changes: 1 addition & 1 deletion website/docs/r/eks_cluster.html.markdown
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ The following arguments are supported:

* `endpoint_private_access` - (Optional) Indicates whether or not the Amazon EKS private API server endpoint is enabled. Default is `false`.
* `endpoint_public_access` - (Optional) Indicates whether or not the Amazon EKS public API server endpoint is enabled. Default is `true`.
* `public_access_cidrs` - (Optional) List of CIDR blocks. Indicates which CIDR blocks can access the Amazon EKS public API server endpoint.
* `public_access_cidrs` - (Optional) List of CIDR blocks. Indicates which CIDR blocks can access the Amazon EKS public API server endpoint when enabled. EKS defaults this to a list with `0.0.0.0/0`. Terraform will only perform drift detection of its value when present in a configuration.
* `security_group_ids` – (Optional) List of security group IDs for the cross-account elastic network interfaces that Amazon EKS creates to use to allow communication between your worker nodes and the Kubernetes control plane.
* `subnet_ids` – (Required) List of subnet IDs. Must be in at least two different availability zones. Amazon EKS creates cross-account elastic network interfaces in these subnets to allow communication between your worker nodes and the Kubernetes control plane.

Expand Down

0 comments on commit ce59253

Please sign in to comment.