Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

func ValidateARN regex check needs to support additional regions #11444

Closed
jered-miller opened this issue Dec 31, 2019 · 5 comments · Fixed by #11471
Closed

func ValidateARN regex check needs to support additional regions #11444

jered-miller opened this issue Dec 31, 2019 · 5 comments · Fixed by #11471
Labels
bug Addresses a defect in current functionality. partition/aws-iso Pertains to the aws-iso partition. partition/aws-iso-b Pertains to the aws-iso-b partition. provider Pertains to the provider itself, rather than any interaction with AWS.
Milestone

Comments

@jered-miller
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Terraform Version

0.12.16

Affected Resource(s)

  • All resources that call func validateArn

Expected Behavior

Referencing a KMS Key ARN in aws_ami_copy should allow a key to be associated for encryption during the copy.

Actual Behavior

An error occured stating that "This doesn't look like a valid ARN". validateARN does not support certain unlisted AWS regions. The pattern check needs to allow more flexibility in the second tuple for gov regions. i.e. us-XXXX-east-1.

Steps to Reproduce

  1. terraform apply

Important Factoids

This is running in an unlisted AWS region.

References

  • #0000
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Dec 31, 2019
@bflad bflad added bug Addresses a defect in current functionality. provider Pertains to the provider itself, rather than any interaction with AWS. and removed needs-triage Waiting for first response or review from a maintainer. labels Jan 3, 2020
@bflad bflad added partition/aws-iso Pertains to the aws-iso partition. partition/aws-iso-b Pertains to the aws-iso-b partition. labels Jan 3, 2020
@bflad
Copy link
Contributor

bflad commented Jan 3, 2020

Pull request submitted: #11471

@bflad bflad added this to the v2.44.0 milestone Jan 6, 2020
@bflad
Copy link
Contributor

bflad commented Jan 6, 2020

The fix for this has been merged and will release with version 2.44.0 of the Terraform AWS Provider, on Thursday. 👍

@ewbankkit
Copy link
Contributor

@ghost
Copy link

ghost commented Jan 10, 2020

This has been released in version 2.44.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Mar 27, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. partition/aws-iso Pertains to the aws-iso partition. partition/aws-iso-b Pertains to the aws-iso-b partition. provider Pertains to the provider itself, rather than any interaction with AWS.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants