Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong documentation for aws_s3_bucket #12321

Closed
Sytten opened this issue Mar 9, 2020 · 1 comment · Fixed by #12324
Closed

Wrong documentation for aws_s3_bucket #12321

Sytten opened this issue Mar 9, 2020 · 1 comment · Fixed by #12324
Assignees
Labels
documentation Introduces or discusses updates to documentation. service/s3 Issues and PRs that pertain to the s3 service.

Comments

@Sytten
Copy link

Sytten commented Mar 9, 2020

This is related to the changes in #989

The example in the documentation is wrong:

data "aws_canonical_user_id" "current_user" {}

resource "aws_s3_bucket" "bucket" {
  bucket = "mybucket"

  grant {
    id         = "${data.aws_canonical_user_id.current_user.id}"
    type       = "CanonicalUser"
    permission = ["FULL_ACCESS"]
  }

  grant {
    type       = "Group"
    permission = ["READ", "WRITE"]
    uri        = "http://acs.amazonaws.com/groups/s3/LogDelivery"
  }
}

Should be:

data "aws_canonical_user_id" "current_user" {}

resource "aws_s3_bucket" "bucket" {
  bucket = "mybucket"

  grant {
    id          = "${data.aws_canonical_user_id.current_user.id}"
    type        = "CanonicalUser"
    permissions = ["FULL_CONTROL"]
  }

  grant {
    type        = "Group"
    permissions = ["READ", "WRITE"]
    uri         = "http://acs.amazonaws.com/groups/s3/LogDelivery"
  }
}
@ghost ghost added the service/s3 Issues and PRs that pertain to the s3 service. label Mar 9, 2020
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Mar 9, 2020
@bflad bflad added documentation Introduces or discusses updates to documentation. and removed needs-triage Waiting for first response or review from a maintainer. labels Mar 25, 2020
@ghost
Copy link

ghost commented May 2, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators May 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/s3 Issues and PRs that pertain to the s3 service.
Projects
None yet
3 participants