Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed S3 Permissions incorrect references and typos #12455

Closed
wants to merge 2 commits into from
Closed

Fixed S3 Permissions incorrect references and typos #12455

wants to merge 2 commits into from

Conversation

jvasallo
Copy link

@jvasallo jvasallo commented Mar 18, 2020 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Release note for CHANGELOG:

NONE

Output from acceptance testing:
Doc fix and typo; no test. Worked with @EkkertRBX on this. Nice catch! :)

@jvasallo jvasallo requested a review from a team March 18, 2020 23:05
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. service/s3 Issues and PRs that pertain to the s3 service. labels Mar 18, 2020
@ewbankkit
Copy link
Contributor

Closes #12321.
Documentation in question was added via #3728.
Similar:

@jvasallo Thanks for this.

@bflad bflad removed the needs-triage Waiting for first response or review from a maintainer. label Mar 25, 2020
@gdavison
Copy link
Contributor

gdavison commented Apr 1, 2020

Thanks for the PR, @jvasallo! I've merged #12426, but it's great that we had a few fixes for this

@gdavison gdavison closed this Apr 1, 2020
@ghost
Copy link

ghost commented May 2, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators May 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@gdavison gdavison

Labels
documentation Introduces or discusses updates to documentation. service/s3 Issues and PRs that pertain to the s3 service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jvasallo @ewbankkit @gdavison @bflad