Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subsequent plan/apply forces global cluster recreation when source cluster's storage_encrypted=true #15177

Closed
marinsalinas opened this issue Sep 16, 2020 · 5 comments · Fixed by #15916
Assignees
Labels
bug Addresses a defect in current functionality. service/rds Issues and PRs that pertain to the rds service.
Milestone

Comments

@marinsalinas
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Terraform CLI and Terraform AWS Provider Version

Affected Resource(s)

  • aws_rds_global_cluster

Terraform Configuration Files

data "aws_kms_alias" "this" {
  name  = "alias/rds"
}


# The source_db_cluster_identifier argument does not currently exist
resource "aws_rds_global_cluster" "global_cluster" {
  # ... other configuration ...
  source_db_cluster_identifier = aws_rds_cluster.example.id
}

resource "aws_rds_cluster" "example" {
  snapshot_identifier = aws_db_cluster_snapshot.example.id

  storage_encrypted = true
  kms_key_id              =  data.aws_kms_alias.this.target_key_arn

  lifecycle {
    ignore_changes = [global_cluster_identifier]
  }
}

Debug Output

Panic Output

Expected Behavior

Subsequent plans should show no changes.

Actual Behavior

The subsequent plan shows a diff on the storage_encrypted attribute since now this attribute is marked as optional, it should be computed as well.

/+ resource "aws_rds_global_cluster" "global_cluster" {
      ...
      - storage_encrypted            = true -> null # forces replacement
    }

Steps to Reproduce

  1. terraform apply
  2. terraform plan

Important Factoids

storage_encrypted should be Computed as well.
https://github.com/terraform-providers/terraform-provider-aws/blob/master/aws/resource_aws_rds_global_cluster.go#L99

@ghost ghost added service/kms Issues and PRs that pertain to the kms service. service/rds Issues and PRs that pertain to the rds service. labels Sep 16, 2020
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Sep 16, 2020
@anGie44 anGie44 added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. service/kms Issues and PRs that pertain to the kms service. labels Sep 16, 2020
@callaingit
Copy link

I had the same issue, needed to add a lifecycle to ignore changes on storage_encrypted as a work-around.

@bflad bflad self-assigned this Oct 29, 2020
@bflad
Copy link
Contributor

bflad commented Oct 29, 2020

I'm working on similar fixes for other attributes in the RDS resources, so picking this up as part of those efforts.

bflad added a commit that referenced this issue Oct 29, 2020
…ted source_db_cluster_identifier without storage_encrypted

Reference: #15177

Output from acceptance testing:

```
--- PASS: TestAccAWSRdsGlobalCluster_basic (25.00s)
--- PASS: TestAccAWSRdsGlobalCluster_DatabaseName (35.93s)
--- PASS: TestAccAWSRdsGlobalCluster_DeletionProtection (35.59s)
--- PASS: TestAccAWSRdsGlobalCluster_disappears (19.24s)
--- PASS: TestAccAWSRdsGlobalCluster_Engine_Aurora (25.19s)
--- PASS: TestAccAWSRdsGlobalCluster_EngineVersion_Aurora (25.11s)
--- PASS: TestAccAWSRdsGlobalCluster_EngineVersion_AuroraMySQL (25.27s)
--- PASS: TestAccAWSRdsGlobalCluster_EngineVersion_AuroraPostgresql (23.12s)
--- PASS: TestAccAWSRdsGlobalCluster_SourceDbClusterIdentifier (129.42s)
--- PASS: TestAccAWSRdsGlobalCluster_SourceDbClusterIdentifier_StorageEncrypted (128.96s)
--- PASS: TestAccAWSRdsGlobalCluster_StorageEncrypted (37.43s)
```
bflad added a commit that referenced this issue Oct 29, 2020
…ted source_db_cluster_identifier without storage_encrypted (#15916)

Reference: #15177

Output from acceptance testing:

```
--- PASS: TestAccAWSRdsGlobalCluster_basic (25.00s)
--- PASS: TestAccAWSRdsGlobalCluster_DatabaseName (35.93s)
--- PASS: TestAccAWSRdsGlobalCluster_DeletionProtection (35.59s)
--- PASS: TestAccAWSRdsGlobalCluster_disappears (19.24s)
--- PASS: TestAccAWSRdsGlobalCluster_Engine_Aurora (25.19s)
--- PASS: TestAccAWSRdsGlobalCluster_EngineVersion_Aurora (25.11s)
--- PASS: TestAccAWSRdsGlobalCluster_EngineVersion_AuroraMySQL (25.27s)
--- PASS: TestAccAWSRdsGlobalCluster_EngineVersion_AuroraPostgresql (23.12s)
--- PASS: TestAccAWSRdsGlobalCluster_SourceDbClusterIdentifier (129.42s)
--- PASS: TestAccAWSRdsGlobalCluster_SourceDbClusterIdentifier_StorageEncrypted (128.96s)
--- PASS: TestAccAWSRdsGlobalCluster_StorageEncrypted (37.43s)
```
@bflad bflad added this to the v3.13.0 milestone Oct 29, 2020
@bflad
Copy link
Contributor

bflad commented Oct 29, 2020

The fix for this has been merged and will release with version 3.13.0 of the Terraform AWS Provider, likely later today. 👍

@ghost
Copy link

ghost commented Oct 29, 2020

This has been released in version 3.13.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Nov 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Nov 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/rds Issues and PRs that pertain to the rds service.
Projects
None yet
4 participants