rd/aws_imagebuilder_image - add support for container_recipe_arn

[kamilturek]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #23380.

Output from acceptance testing:

$ make testacc TESTS="TestAccImageBuilderImage_containerRecipeARN" PKG=imagebuilder
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/imagebuilder/... -v -count 1 -parallel 20 -run='TestAccImageBuilderImage_containerRecipeARN'  -timeout 180m
=== RUN   TestAccImageBuilderImage_containerRecipeARN
=== PAUSE TestAccImageBuilderImage_containerRecipeARN
=== CONT  TestAccImageBuilderImage_containerRecipeARN
--- PASS: TestAccImageBuilderImage_containerRecipeARN (666.47s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/imagebuilder       668.203s

make testacc TESTS="TestAccImageBuilderImageDataSource_ARN_containerRecipeARN" PKG=imagebuilder
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/imagebuilder/... -v -count 1 -parallel 20 -run='TestAccImageBuilderImageDataSource_ARN_containerRecipeARN'  -timeout 180m
=== RUN   TestAccImageBuilderImageDataSource_ARN_containerRecipeARN
=== PAUSE TestAccImageBuilderImageDataSource_ARN_containerRecipeARN
=== CONT  TestAccImageBuilderImageDataSource_ARN_containerRecipeARN
--- PASS: TestAccImageBuilderImageDataSource_ARN_containerRecipeARN (549.80s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/imagebuilder       551.440s

[kamilturek]

I did not reuse the testAccImageBaseConfig as the base needed for container builds differs too much.

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccImageBuilderImageDataSource_\|TestAccImageBuilderImage_' PKG=imagebuilder ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/imagebuilder/... -v -count 1 -parallel 3  -run=TestAccImageBuilderImageDataSource_\|TestAccImageBuilderImage_ -timeout 180m
=== RUN   TestAccImageBuilderImageDataSource_ARN_aws
=== PAUSE TestAccImageBuilderImageDataSource_ARN_aws
=== RUN   TestAccImageBuilderImageDataSource_ARN_self
=== PAUSE TestAccImageBuilderImageDataSource_ARN_self
=== RUN   TestAccImageBuilderImageDataSource_ARN_containerRecipeARN
=== PAUSE TestAccImageBuilderImageDataSource_ARN_containerRecipeARN
=== RUN   TestAccImageBuilderImage_basic
=== PAUSE TestAccImageBuilderImage_basic
=== RUN   TestAccImageBuilderImage_disappears
=== PAUSE TestAccImageBuilderImage_disappears
=== RUN   TestAccImageBuilderImage_distributionARN
=== PAUSE TestAccImageBuilderImage_distributionARN
=== RUN   TestAccImageBuilderImage_enhancedImageMetadataEnabled
=== PAUSE TestAccImageBuilderImage_enhancedImageMetadataEnabled
=== RUN   TestAccImageBuilderImage_ImageTests_imageTestsEnabled
=== PAUSE TestAccImageBuilderImage_ImageTests_imageTestsEnabled
=== RUN   TestAccImageBuilderImage_ImageTests_timeoutMinutes
=== PAUSE TestAccImageBuilderImage_ImageTests_timeoutMinutes
=== RUN   TestAccImageBuilderImage_tags
=== PAUSE TestAccImageBuilderImage_tags
=== RUN   TestAccImageBuilderImage_containerRecipeARN
=== PAUSE TestAccImageBuilderImage_containerRecipeARN
=== CONT  TestAccImageBuilderImageDataSource_ARN_aws
=== CONT  TestAccImageBuilderImage_containerRecipeARN
=== CONT  TestAccImageBuilderImage_distributionARN
--- PASS: TestAccImageBuilderImageDataSource_ARN_aws (13.84s)
=== CONT  TestAccImageBuilderImageDataSource_ARN_containerRecipeARN
--- PASS: TestAccImageBuilderImage_containerRecipeARN (564.81s)
=== CONT  TestAccImageBuilderImageDataSource_ARN_self
--- PASS: TestAccImageBuilderImageDataSource_ARN_containerRecipeARN (661.21s)
=== CONT  TestAccImageBuilderImage_disappears
--- PASS: TestAccImageBuilderImage_distributionARN (1545.70s)
=== CONT  TestAccImageBuilderImage_ImageTests_timeoutMinutes
--- PASS: TestAccImageBuilderImageDataSource_ARN_self (1423.35s)
=== CONT  TestAccImageBuilderImage_tags
--- PASS: TestAccImageBuilderImage_disappears (1411.24s)
=== CONT  TestAccImageBuilderImage_basic
--- PASS: TestAccImageBuilderImage_ImageTests_timeoutMinutes (1409.18s)
=== CONT  TestAccImageBuilderImage_enhancedImageMetadataEnabled
--- PASS: TestAccImageBuilderImage_tags (1324.12s)
=== CONT  TestAccImageBuilderImage_ImageTests_imageTestsEnabled
--- PASS: TestAccImageBuilderImage_basic (1418.64s)
--- PASS: TestAccImageBuilderImage_enhancedImageMetadataEnabled (1165.68s)
--- PASS: TestAccImageBuilderImage_ImageTests_imageTestsEnabled (1042.40s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/imagebuilder	4357.913s

[ewbankkit]

@kamilturek Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v4.6.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.