Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rd/aws_imagebuilder_image - add support for container_recipe_arn #23647

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changelog/23647.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
```release-note:enhancement
resource/aws_imagebuilder_image: Add `container_recipe_arn` argument
```

```release-note:enhancement
data-source/aws_imagebuilder_image: Add `container_recipe_arn` attribute
```
18 changes: 17 additions & 1 deletion internal/service/imagebuilder/image.go
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,13 @@ func ResourceImage() *schema.Resource {
Type: schema.TypeString,
Computed: true,
},
"container_recipe_arn": {
Type: schema.TypeString,
Optional: true,
ForceNew: true,
ValidateFunc: validation.StringMatch(regexp.MustCompile(`^arn:aws[^:]*:imagebuilder:[^:]+:(?:\d{12}|aws):container-recipe/[a-z0-9-_]+/\d+\.\d+\.\d+$`), "valid container recipe ARN must be provided"),
ExactlyOneOf: []string{"container_recipe_arn", "image_recipe_arn"},
},
"distribution_configuration_arn": {
Type: schema.TypeString,
Optional: true,
Expand All @@ -53,9 +60,10 @@ func ResourceImage() *schema.Resource {
},
"image_recipe_arn": {
Type: schema.TypeString,
Required: true,
Optional: true,
ForceNew: true,
ValidateFunc: validation.StringMatch(regexp.MustCompile(`^arn:aws[^:]*:imagebuilder:[^:]+:(?:\d{12}|aws):image-recipe/[a-z0-9-_]+/\d+\.\d+\.\d+$`), "valid image recipe ARN must be provided"),
ExactlyOneOf: []string{"container_recipe_arn", "image_recipe_arn"},
},
"image_tests_configuration": {
Type: schema.TypeList,
Expand Down Expand Up @@ -157,6 +165,10 @@ func resourceImageCreate(d *schema.ResourceData, meta interface{}) error {
EnhancedImageMetadataEnabled: aws.Bool(d.Get("enhanced_image_metadata_enabled").(bool)),
}

if v, ok := d.GetOk("container_recipe_arn"); ok {
input.ContainerRecipeArn = aws.String(v.(string))
}

if v, ok := d.GetOk("distribution_configuration_arn"); ok {
input.DistributionConfigurationArn = aws.String(v.(string))
}
Expand Down Expand Up @@ -226,6 +238,10 @@ func resourceImageRead(d *schema.ResourceData, meta interface{}) error {
d.Set("arn", image.Arn)
d.Set("date_created", image.DateCreated)

if image.ContainerRecipe != nil {
d.Set("container_recipe_arn", image.ContainerRecipe.Arn)
}

if image.DistributionConfiguration != nil {
d.Set("distribution_configuration_arn", image.DistributionConfiguration.Arn)
}
Expand Down
8 changes: 8 additions & 0 deletions internal/service/imagebuilder/image_data_source.go
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,10 @@ func DataSourceImage() *schema.Resource {
Type: schema.TypeString,
Computed: true,
},
"container_recipe_arn": {
Type: schema.TypeString,
Computed: true,
},
"date_created": {
Type: schema.TypeString,
Computed: true,
Expand Down Expand Up @@ -151,6 +155,10 @@ func dataSourceImageRead(d *schema.ResourceData, meta interface{}) error {
d.Set("build_version_arn", image.Arn)
d.Set("date_created", image.DateCreated)

if image.ContainerRecipe != nil {
d.Set("container_recipe_arn", image.ContainerRecipe.Arn)
}

if image.DistributionConfiguration != nil {
d.Set("distribution_configuration_arn", image.DistributionConfiguration.Arn)
}
Expand Down
153 changes: 153 additions & 0 deletions internal/service/imagebuilder/image_data_source_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,28 @@ func TestAccImageBuilderImageDataSource_ARN_self(t *testing.T) {
})
}

func TestAccImageBuilderImageDataSource_ARN_containerRecipeARN(t *testing.T) {
rName := sdkacctest.RandomWithPrefix(acctest.ResourcePrefix)
dataSourceName := "data.aws_imagebuilder_image.test"
resourceName := "aws_imagebuilder_image.test"

resource.ParallelTest(t, resource.TestCase{
PreCheck: func() { acctest.PreCheck(t) },
ErrorCheck: acctest.ErrorCheck(t, imagebuilder.EndpointsID),
ProviderFactories: acctest.ProviderFactories,
CheckDestroy: testAccCheckImageDestroy,
Steps: []resource.TestStep{
{
Config: testAccImageARNContainerRecipeARNDataSourceConfig(rName),
Check: resource.ComposeTestCheckFunc(
resource.TestCheckResourceAttrPair(dataSourceName, "arn", resourceName, "arn"),
resource.TestCheckResourceAttrPair(dataSourceName, "container_recipe_arn", resourceName, "container_recipe_arn"),
),
},
},
})
}

func testAccImageARNDataSourceConfig() string {
return `
data "aws_partition" "current" {}
Expand Down Expand Up @@ -205,3 +227,134 @@ data "aws_imagebuilder_image" "test" {
}
`, rName)
}

func testAccImageARNContainerRecipeARNDataSourceConfig(rName string) string {
return fmt.Sprintf(`
data "aws_region" "current" {}

data "aws_partition" "current" {}

resource "aws_vpc" "test" {
cidr_block = "10.0.0.0/16"
}

resource "aws_default_route_table" "test" {
default_route_table_id = aws_vpc.test.default_route_table_id

route {
cidr_block = "0.0.0.0/0"
gateway_id = aws_internet_gateway.test.id
}
}

resource "aws_default_security_group" "test" {
vpc_id = aws_vpc.test.id

egress {
cidr_blocks = ["0.0.0.0/0"]
from_port = 0
protocol = "-1"
to_port = 0
}

ingress {
from_port = 0
protocol = -1
self = true
to_port = 0
}
}

resource "aws_internet_gateway" "test" {
vpc_id = aws_vpc.test.id
}

resource "aws_subnet" "test" {
cidr_block = cidrsubnet(aws_vpc.test.cidr_block, 8, 0)
map_public_ip_on_launch = true
vpc_id = aws_vpc.test.id
}

resource "aws_iam_role" "test" {
assume_role_policy = jsonencode({
Version = "2012-10-17"
Statement = [{
Action = "sts:AssumeRole"
Effect = "Allow"
Principal = {
Service = "ec2.${data.aws_partition.current.dns_suffix}"
}
Sid = ""
}]
})
name = %[1]q
}

resource "aws_iam_role_policy_attachment" "AmazonSSMManagedInstanceCore" {
policy_arn = "arn:${data.aws_partition.current.partition}:iam::aws:policy/AmazonSSMManagedInstanceCore"
role = aws_iam_role.test.name
}

resource "aws_iam_role_policy_attachment" "EC2InstanceProfileForImageBuilderECRContainerBuilds" {
policy_arn = "arn:${data.aws_partition.current.partition}:iam::aws:policy/EC2InstanceProfileForImageBuilderECRContainerBuilds"
role = aws_iam_role.test.name
}

resource "aws_iam_instance_profile" "test" {
name = aws_iam_role.test.name
role = aws_iam_role.test.name

depends_on = [
aws_iam_role_policy_attachment.AmazonSSMManagedInstanceCore,
aws_iam_role_policy_attachment.EC2InstanceProfileForImageBuilderECRContainerBuilds
]
}

resource "aws_ecr_repository" "test" {
name = %[1]q
}

data "aws_imagebuilder_component" "update-linux" {
arn = "arn:${data.aws_partition.current.partition}:imagebuilder:${data.aws_region.current.name}:aws:component/update-linux/1.0.0"
}

resource "aws_imagebuilder_container_recipe" "test" {
component {
component_arn = data.aws_imagebuilder_component.update-linux.arn
}

dockerfile_template_data = <<EOF
FROM {{{ imagebuilder:parentImage }}}
{{{ imagebuilder:environments }}}
{{{ imagebuilder:components }}}
EOF

name = %[1]q
container_type = "DOCKER"
parent_image = "arn:${data.aws_partition.current.partition}:imagebuilder:${data.aws_region.current.name}:aws:image/amazon-linux-x86-latest/x.x.x"
version = "1.0.0"
target_repository {
repository_name = aws_ecr_repository.test.name
service = "ECR"
}
}

resource "aws_imagebuilder_infrastructure_configuration" "test" {
instance_profile_name = aws_iam_instance_profile.test.name
name = %[1]q
security_group_ids = [aws_default_security_group.test.id]
subnet_id = aws_subnet.test.id

depends_on = [aws_default_route_table.test]
}

resource "aws_imagebuilder_image" "test" {
container_recipe_arn = aws_imagebuilder_container_recipe.test.arn
infrastructure_configuration_arn = aws_imagebuilder_infrastructure_configuration.test.arn
}

data "aws_imagebuilder_image" "test" {
arn = aws_imagebuilder_image.test.arn
}
`, rName)
}
Loading