Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs]: Default kinesis_firehose_delivery_stream parameter values have changed in AWS #33014

Closed
imaginaryCorn opened this issue Aug 14, 2023 · 3 comments · Fixed by #35137
Closed
Labels
documentation Introduces or discusses updates to documentation. service/firehose Issues and PRs that pertain to the firehose service.
Milestone

Comments

@imaginaryCorn
Copy link

imaginaryCorn commented Aug 14, 2023

Documentation Link

https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/kinesis_firehose_delivery_stream.html#parameters

Description

The parameters block within kinesis_firehose_delivery_stream has a known quirk where state is not stored if the parameter_value is the same as the current AWS default. We recently encountered this issue again, where the state for the firehose stream parameters did not keep in Terraform:

# xxx.aws_kinesis_firehose_delivery_stream.firehose will be updated in-place
resource "aws_kinesis_firehose_delivery_stream" "firehose" {
--
  | id             = "arn:aws:firehose:*:*:deliverystream/xx"
  | name           = "xx"
  | tags           = {
  | "PreventDestroy" = "true"
  | "env"            = "development"
  | }
  | # (5 unchanged attributes hidden)
  |  
  | ~ extended_s3_configuration {
  | # (8 unchanged attributes hidden)
  |  
  | ~ processing_configuration {
  | # (1 unchanged attribute hidden)
  |  
  | ~ processors {
  | # (1 unchanged attribute hidden)
  |  
  | - parameters {
  | - parameter_name  = "BufferSizeInMBs" -> null
  | - parameter_value = "1" -> null
  | }
  |  
  | # (1 unchanged block hidden)
  | }
  | }
# ...

Knowing about the existing open issue #9827, we checked AWS for changes and the console showed us that creating a new firehose with "Transform and convert records" setting sets the value to 1mb instead of the previous default of 3. The API reference for firehose confirmed this is there new default.

The parameters array object setting in the kinesis_firehose_delivery_stream documentation requires updating to reflect this backend change that affects the known perpetual state issue with firehoses.

References

Relates #9827.
Relates #19936.

AWS API Reference for Firehose parameters block: https://docs.aws.amazon.com/firehose/latest/APIReference/API_ProcessorParameter.html

Would you like to implement a fix?

None

@imaginaryCorn imaginaryCorn added the documentation Introduces or discusses updates to documentation. label Aug 14, 2023
@github-actions github-actions bot added the service/firehose Issues and PRs that pertain to the firehose service. label Aug 14, 2023
@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Aug 14, 2023
@justinretzolk justinretzolk removed the needs-triage Waiting for first response or review from a maintainer. label Aug 16, 2023
ewbankkit pushed a commit that referenced this issue Jan 5, 2024
This is the correct value, though 3 MB may have been at some point in
the past. This addresses the perpetual differences found in the state
currently due to the default creation being 1 MB, and state default
expecting 3 MB. References can be seen in #9827 and #19936. This also
fixes #33014.
@github-actions github-actions bot added this to the v5.32.0 milestone Jan 5, 2024
Copy link

This functionality has been released in v5.32.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/firehose Issues and PRs that pertain to the firehose service.
Projects
None yet
2 participants