-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rotate_immediately argument to secret rotation #35105
Add rotate_immediately argument to secret rotation #35105
Conversation
Community NoteVoting for Prioritization
For Submitters
|
aws_secretsmanager_secret_rotation `rotate_immediatley`
This functionality has been released in v5.33.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
"rotate_immediately": { | ||
Type: schema.TypeBool, | ||
Optional: true, | ||
Default: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The markdown doc says this should default to false. I believe this is causing all newly made secrets (potentially just all terraform apply's) to try to rotate immediately, potentially causing issues or unexpected results.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @MagikHands, this should be an error in documentation.
The default behavior should be set to true, just as the SDK.
The original issue mentioned to have the possibility to disable this default behavior.
Github issue
If you agree with this please open a new issue to update documentation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MagikHands, I have create an issue to report this : #35702
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Add support for the
rotate_immediatley
argument for the resourceaws_secretsmanager_secret_rotation
Relations
Closes #34961
References
AWS SDK V1
Output from Acceptance Testing