fix(rds): trigger subsequent instance update operation for PITR case masterUserPassword

[kolvin]

Description

This MR will trigger a secondary API call to modify an instance in the case of PITR restores for masterUserPassword.

I'm aiming to replicate the same behavior as seen for Snapshot restores - src

Relations

Closes #35566.
Relates #33699.

References

• https://github.com/hashicorp/terraform-provider-aws/blob/main/internal/service/rds/instance.go#L1175-L1178

Output from Acceptance Testing

✗  AWS_PROFILE=default make testacc TESTS='TestAccRDSInstance_RestoreToPointInTime_*' PKG=rds
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 20 -run='TestAccRDSInstance_RestoreToPointInTime_*'  -timeout 360m
=== RUN   TestAccRDSInstance_RestoreToPointInTime_sourceIdentifier
=== PAUSE TestAccRDSInstance_RestoreToPointInTime_sourceIdentifier
=== RUN   TestAccRDSInstance_RestoreToPointInTime_sourceResourceID
=== PAUSE TestAccRDSInstance_RestoreToPointInTime_sourceResourceID
=== RUN   TestAccRDSInstance_RestoreToPointInTime_monitoring
=== PAUSE TestAccRDSInstance_RestoreToPointInTime_monitoring
=== RUN   TestAccRDSInstance_RestoreToPointInTime_ManagedMasterPassword
=== PAUSE TestAccRDSInstance_RestoreToPointInTime_ManagedMasterPassword
=== CONT  TestAccRDSInstance_RestoreToPointInTime_sourceIdentifier
=== CONT  TestAccRDSInstance_RestoreToPointInTime_ManagedMasterPassword
=== CONT  TestAccRDSInstance_RestoreToPointInTime_monitoring
=== CONT  TestAccRDSInstance_RestoreToPointInTime_sourceResourceID
--- PASS: TestAccRDSInstance_RestoreToPointInTime_sourceIdentifier (1337.23s)
--- PASS: TestAccRDSInstance_RestoreToPointInTime_sourceResourceID (1427.96s)
--- PASS: TestAccRDSInstance_RestoreToPointInTime_ManagedMasterPassword (1501.00s)
--- PASS: TestAccRDSInstance_RestoreToPointInTime_monitoring (1688.57s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	1694.555s
...

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[github-actions]

Welcome @kolvin 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccRDSInstance_RestoreToPointInTime_sourceIdentifier' PKG=rds
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 20  -run=TestAccRDSInstance_RestoreToPointInTime_sourceIdentifier -timeout 360m
=== RUN   TestAccRDSInstance_RestoreToPointInTime_sourceIdentifier
=== PAUSE TestAccRDSInstance_RestoreToPointInTime_sourceIdentifier
=== CONT  TestAccRDSInstance_RestoreToPointInTime_sourceIdentifier
--- PASS: TestAccRDSInstance_RestoreToPointInTime_sourceIdentifier (1671.65s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	1682.480s

[ewbankkit]

@kolvin Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v5.36.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[kolvin]

Just tested this and now getting the expected behavior for PITR restores 💯

Thanks!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.