b/aws_vpc_ipam_pool_cidr_allocation-read description and netmask_length

[GlennChia]

Description

Practitioner-facing changes

• Read description and netmask_length into state. This allows the resource to be imported when those arguments are specified
• Update documentation to specify arguments as force new

Internal changes

• Test for description create, import, re-create
• Test for netmask_length import, re-create
• Test for netmask_length attribute when cidr argument is used in create

Relations

Closes #38613
Closes #38614

References

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccIPAMPoolCIDRAllocation_' PKG=ec2 ACCTEST_PARALLELISM=1
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 1  -run=TestAccIPAMPoolCIDRAllocation_ -timeout 360m
=== RUN   TestAccIPAMPoolCIDRAllocation_ipv4Basic
=== PAUSE TestAccIPAMPoolCIDRAllocation_ipv4Basic
=== RUN   TestAccIPAMPoolCIDRAllocation_ipv4Description
=== PAUSE TestAccIPAMPoolCIDRAllocation_ipv4Description
=== RUN   TestAccIPAMPoolCIDRAllocation_disappears
=== PAUSE TestAccIPAMPoolCIDRAllocation_disappears
=== RUN   TestAccIPAMPoolCIDRAllocation_ipv4BasicNetmask
=== PAUSE TestAccIPAMPoolCIDRAllocation_ipv4BasicNetmask
=== RUN   TestAccIPAMPoolCIDRAllocation_ipv4DisallowedCIDR
=== PAUSE TestAccIPAMPoolCIDRAllocation_ipv4DisallowedCIDR
=== RUN   TestAccIPAMPoolCIDRAllocation_multiple
=== PAUSE TestAccIPAMPoolCIDRAllocation_multiple
=== RUN   TestAccIPAMPoolCIDRAllocation_differentRegion
=== PAUSE TestAccIPAMPoolCIDRAllocation_differentRegion
=== CONT  TestAccIPAMPoolCIDRAllocation_ipv4Basic
--- PASS: TestAccIPAMPoolCIDRAllocation_ipv4Basic (90.99s)
=== CONT  TestAccIPAMPoolCIDRAllocation_ipv4DisallowedCIDR
--- PASS: TestAccIPAMPoolCIDRAllocation_ipv4DisallowedCIDR (89.77s)
=== CONT  TestAccIPAMPoolCIDRAllocation_differentRegion
--- PASS: TestAccIPAMPoolCIDRAllocation_differentRegion (90.64s)
=== CONT  TestAccIPAMPoolCIDRAllocation_multiple
--- PASS: TestAccIPAMPoolCIDRAllocation_multiple (144.52s)
=== CONT  TestAccIPAMPoolCIDRAllocation_disappears
--- PASS: TestAccIPAMPoolCIDRAllocation_disappears (96.31s)
=== CONT  TestAccIPAMPoolCIDRAllocation_ipv4BasicNetmask
--- PASS: TestAccIPAMPoolCIDRAllocation_ipv4BasicNetmask (118.75s)
=== CONT  TestAccIPAMPoolCIDRAllocation_ipv4Description
--- PASS: TestAccIPAMPoolCIDRAllocation_ipv4Description (119.70s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        750.878s

...

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccIPAMPoolCIDRAllocation_' PKG=ec2 ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.5 test ./internal/service/ec2/... -v -count 1 -parallel 3  -run=TestAccIPAMPoolCIDRAllocation_ -timeout 360m
=== RUN   TestAccIPAMPoolCIDRAllocation_ipv4Basic
=== PAUSE TestAccIPAMPoolCIDRAllocation_ipv4Basic
=== RUN   TestAccIPAMPoolCIDRAllocation_ipv4Description
=== PAUSE TestAccIPAMPoolCIDRAllocation_ipv4Description
=== RUN   TestAccIPAMPoolCIDRAllocation_disappears
=== PAUSE TestAccIPAMPoolCIDRAllocation_disappears
=== RUN   TestAccIPAMPoolCIDRAllocation_ipv4BasicNetmask
=== PAUSE TestAccIPAMPoolCIDRAllocation_ipv4BasicNetmask
=== RUN   TestAccIPAMPoolCIDRAllocation_ipv4DisallowedCIDR
=== PAUSE TestAccIPAMPoolCIDRAllocation_ipv4DisallowedCIDR
=== RUN   TestAccIPAMPoolCIDRAllocation_multiple
=== PAUSE TestAccIPAMPoolCIDRAllocation_multiple
=== RUN   TestAccIPAMPoolCIDRAllocation_differentRegion
=== PAUSE TestAccIPAMPoolCIDRAllocation_differentRegion
=== CONT  TestAccIPAMPoolCIDRAllocation_ipv4Basic
=== CONT  TestAccIPAMPoolCIDRAllocation_ipv4DisallowedCIDR
=== CONT  TestAccIPAMPoolCIDRAllocation_disappears
--- PASS: TestAccIPAMPoolCIDRAllocation_ipv4DisallowedCIDR (70.25s)
=== CONT  TestAccIPAMPoolCIDRAllocation_ipv4BasicNetmask
--- PASS: TestAccIPAMPoolCIDRAllocation_ipv4Basic (70.94s)
=== CONT  TestAccIPAMPoolCIDRAllocation_ipv4Description
--- PASS: TestAccIPAMPoolCIDRAllocation_disappears (71.57s)
=== CONT  TestAccIPAMPoolCIDRAllocation_differentRegion
--- PASS: TestAccIPAMPoolCIDRAllocation_differentRegion (80.61s)
=== CONT  TestAccIPAMPoolCIDRAllocation_multiple
--- PASS: TestAccIPAMPoolCIDRAllocation_ipv4Description (89.89s)
--- PASS: TestAccIPAMPoolCIDRAllocation_ipv4BasicNetmask (91.09s)
--- PASS: TestAccIPAMPoolCIDRAllocation_multiple (69.28s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	226.545s

[ewbankkit]

@GlennChia Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v5.61.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.