Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow enabling/disabling the 'multi-header' attribute on a lambda target group #7637

Closed
paultyng opened this issue Feb 21, 2019 · 4 comments · Fixed by #7648
Closed

Allow enabling/disabling the 'multi-header' attribute on a lambda target group #7637

paultyng opened this issue Feb 21, 2019 · 4 comments · Fixed by #7648
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/elbv2 Issues and PRs that pertain to the elbv2 service.
Milestone
v2.1.0

Comments

@paultyng
Copy link
Contributor

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

AWS has the ability to enable this attribute in the console. It appears this is also possible with the following API calls:

https://docs.aws.amazon.com/elasticloadbalancing/latest/APIReference/API_ModifyTargetGroupAttributes.html

https://docs.aws.amazon.com/sdk-for-go/api/service/elbv2/#ELBV2.ModifyTargetGroupAttributes

New or Affected Resource(s)

  • aws_lb_target_group

Potential Terraform Configuration

# Copy-paste your Terraform configurations here - for large Terraform configs,
# please use a service like Dropbox and share a link to the ZIP file. For
# security, you can also encrypt the files using our GPG public key.

References

  • #0000
@paultyng paultyng added the enhancement Requests to existing resources that expand the functionality or scope. label Feb 21, 2019
@bflad bflad added the service/elbv2 Issues and PRs that pertain to the elbv2 service. label Feb 21, 2019
bflad added a commit that referenced this issue Feb 22, 2019
@bflad
resource/aws_lb_target_group: Add lambda_multi_value_headers_enabled …
03849bc 
…argument

Reference: #7637

Output from acceptance testing:

```
--- PASS: TestAccAWSALBTargetGroup_lambda (13.37s)
--- PASS: TestAccAWSALBTargetGroup_missingPortProtocolVpc (17.64s)
--- PASS: TestAccAWSALBTargetGroup_namePrefix (23.80s)
--- PASS: TestAccAWSALBTargetGroup_generatedName (24.12s)
--- PASS: TestAccAWSALBTargetGroup_basic (24.63s)
--- PASS: TestAccAWSALBTargetGroup_lambdaMultiValueHeadersEnabled (30.06s)
--- PASS: TestAccAWSALBTargetGroup_setAndUpdateSlowStart (39.47s)
--- PASS: TestAccAWSALBTargetGroup_tags (40.23s)
--- PASS: TestAccAWSALBTargetGroup_changeNameForceNew (41.56s)
--- PASS: TestAccAWSALBTargetGroup_changePortForceNew (41.67s)
--- PASS: TestAccAWSALBTargetGroup_changeVpcForceNew (43.88s)
--- PASS: TestAccAWSALBTargetGroup_updateHealthCheck (46.08s)
--- PASS: TestAccAWSALBTargetGroup_changeProtocolForceNew (52.34s)
--- PASS: TestAccAWSALBTargetGroup_updateSticknessEnabled (55.45s)
```
@bflad bflad mentioned this issue Feb 22, 2019
Merged
@bflad
Copy link
Contributor

bflad commented Feb 22, 2019

Pull request submitted: #7648

@bflad bflad added this to the v2.1.0 milestone Mar 1, 2019
@bflad
Copy link
Contributor

bflad commented Mar 1, 2019

Support for this new attribute has been merged and will release with version 2.1.0 of the Terraform AWS Provider, likely middle of next week.

@bflad
Copy link
Contributor

bflad commented Mar 8, 2019

This has been released in version 2.1.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@darkwizard242 darkwizard242 mentioned this issue Mar 15, 2019
Closed
@ghost
Copy link

ghost commented Mar 31, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/elbv2 Issues and PRs that pertain to the elbv2 service.
Projects
None yet
Milestone
v2.1.0
2 participants
@bflad @paultyng