Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SES Noification Settings #931

Closed
benoj opened this issue Jun 21, 2017 · 3 comments
Closed

SES Noification Settings #931

benoj opened this issue Jun 21, 2017 · 3 comments
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/ses Issues and PRs that pertain to the ses service.
Milestone
v1.14.0

Comments

@benoj
Copy link

benoj commented Jun 21, 2017

At present aws_ses_domain_identity only allows for me to configure the domain.
I would like to configure the Topic Configuration i.e. bounce/complaint/delivery SNS topics.
@benoj
Copy link
Author

benoj commented Jun 22, 2017

Having had a look at the APIs, looks like something similar to aws_s3_bucket_notification using the SetIdentityNotificationTopic API

@benoj benoj mentioned this issue Jun 22, 2017
Closed
@stack72 stack72 added the enhancement Requests to existing resources that expand the functionality or scope. label Jul 7, 2017
hussfelt added a commit to hussfelt/terraform-provider-aws that referenced this issue Dec 12, 2017
@hussfelt
hashicorp#931 adjust to comments, add validators
f81baa5
hussfelt added a commit to hussfelt/terraform-provider-aws that referenced this issue Dec 12, 2017
@hussfelt
hashicorp#931 Adding a test-base, not yet run
947c93f
@hussfelt hussfelt mentioned this issue Dec 12, 2017
Merged
hussfelt added a commit to hussfelt/terraform-provider-aws that referenced this issue Dec 12, 2017
@hussfelt
hashicorp#931 import log and strings
6e3ea05
hussfelt added a commit to hussfelt/terraform-provider-aws that referenced this issue Dec 12, 2017
@hussfelt
hashicorp#931 add missing conn
a288769
hussfelt added a commit to hussfelt/terraform-provider-aws that referenced this issue Dec 12, 2017
@hussfelt
hashicorp#931 convert to string
7da17fe
hussfelt added a commit to hussfelt/terraform-provider-aws that referenced this issue Dec 12, 2017
@hussfelt
hashicorp#931 remove .Send() and ajust if-statement to be more compact
d342b41
hussfelt added a commit to hussfelt/terraform-provider-aws that referenced this issue Dec 12, 2017
@hussfelt
hashicorp#931 We have NotificationAttributes, and identity not domain
7bc5068
hussfelt added a commit to hussfelt/terraform-provider-aws that referenced this issue Dec 12, 2017
@hussfelt
hashicorp#931 we should get NotificaitonAttributes, not VerificationA…
1e362d6 
…ttributes
@bflad bflad added the service/ses Issues and PRs that pertain to the ses service. label Jan 28, 2018
hussfelt added a commit to hussfelt/terraform-provider-aws that referenced this issue Apr 1, 2018
@hussfelt
hashicorp#931 adjust to comments, add validators
008bbb6
hussfelt added a commit to hussfelt/terraform-provider-aws that referenced this issue Apr 1, 2018
@hussfelt
hashicorp#931 Adding a test-base, not yet run
96b0c49
hussfelt added a commit to hussfelt/terraform-provider-aws that referenced this issue Apr 1, 2018
@hussfelt
hashicorp#931 import log and strings
5bed6c7
hussfelt added a commit to hussfelt/terraform-provider-aws that referenced this issue Apr 1, 2018
@hussfelt
hashicorp#931 add missing conn
d4da1cb
hussfelt added a commit to hussfelt/terraform-provider-aws that referenced this issue Apr 1, 2018
@hussfelt
hashicorp#931 convert to string
a3994c0
hussfelt added a commit to hussfelt/terraform-provider-aws that referenced this issue Apr 1, 2018
@hussfelt
hashicorp#931 remove .Send() and ajust if-statement to be more compact
4dd6397
hussfelt added a commit to hussfelt/terraform-provider-aws that referenced this issue Apr 1, 2018
@hussfelt
hashicorp#931 We have NotificationAttributes, and identity not domain
e937e01
hussfelt added a commit to hussfelt/terraform-provider-aws that referenced this issue Apr 1, 2018
@hussfelt
hashicorp#931 we should get NotificaitonAttributes, not VerificationA…
f67e36b 
…ttributes
hussfelt added a commit to hussfelt/terraform-provider-aws that referenced this issue Apr 1, 2018
@hussfelt
hashicorp#931 Adding documentation
e96621b
hussfelt added a commit to hussfelt/terraform-provider-aws that referenced this issue Apr 1, 2018
@hussfelt
hashicorp#931 adding reference to resourceAwsSesNotification
e3d7667
hussfelt added a commit to hussfelt/terraform-provider-aws that referenced this issue Apr 1, 2018
@hussfelt
hashicorp#931 Fixing minor nitpicks
13e39ee
hussfelt added a commit to hussfelt/terraform-provider-aws that referenced this issue Apr 1, 2018
@hussfelt
hashicorp#931 Force new resource on these attributes as updating it c…
32d15fb 
…ould create situations where the old notifications still exists
hussfelt added a commit to hussfelt/terraform-provider-aws that referenced this issue Apr 1, 2018
@hussfelt
hashicorp#931 Set an ID so we can reference the resource identifier i…
16136e0 
…n the read function and testing, and allow importing later
hussfelt added a commit to hussfelt/terraform-provider-aws that referenced this issue Apr 1, 2018
@hussfelt
hashicorp#931 Read information from the Terraform resource ID
a6eaef4
hussfelt added a commit to hussfelt/terraform-provider-aws that referenced this issue Apr 1, 2018
@hussfelt
hashicorp#931 skip the err checking with simple *string input
c35f6ed
hussfelt added a commit to hussfelt/terraform-provider-aws that referenced this issue Apr 1, 2018
@hussfelt
hashicorp#931 Read information from the Terraform resource ID
0523289
hussfelt added a commit to hussfelt/terraform-provider-aws that referenced this issue Apr 1, 2018
@hussfelt
hashicorp#931 remove additional commas
484648e
hussfelt added a commit to hussfelt/terraform-provider-aws that referenced this issue Apr 1, 2018
@hussfelt
hashicorp#931 fix code issues
6e50910
hussfelt added a commit to hussfelt/terraform-provider-aws that referenced this issue Apr 1, 2018
@hussfelt
hashicorp#931 format code
ea2faa9
hussfelt added a commit to hussfelt/terraform-provider-aws that referenced this issue Apr 1, 2018
@hussfelt
hashicorp#931 changed variable
86d3bcb
hussfelt added a commit to hussfelt/terraform-provider-aws that referenced this issue Apr 1, 2018
@hussfelt
hashicorp#931 Import validation
b9691dd
hussfelt added a commit to hussfelt/terraform-provider-aws that referenced this issue Apr 1, 2018
@hussfelt
hashicorp#931 Adding a case where we update the notification arn
beaf939
hussfelt added a commit to hussfelt/terraform-provider-aws that referenced this issue Apr 3, 2018
@hussfelt
hashicorp#931 use a random topic name
9627959
hussfelt added a commit to hussfelt/terraform-provider-aws that referenced this issue Apr 3, 2018
@hussfelt
hashicorp#931 missing domain in resource
6288102
hussfelt added a commit to hussfelt/terraform-provider-aws that referenced this issue Apr 3, 2018
@hussfelt
hashicorp#931 missing aws prefix
d2bb12b
hussfelt added a commit to hussfelt/terraform-provider-aws that referenced this issue Apr 3, 2018
@hussfelt
hashicorp#931 better descriptions in howto
49b1e85
hussfelt added a commit to hussfelt/terraform-provider-aws that referenced this issue Apr 3, 2018
@hussfelt
hashicorp#931 use terraform fmt, easier to read
5b4f70e
hussfelt added a commit to hussfelt/terraform-provider-aws that referenced this issue Apr 3, 2018
@hussfelt
hashicorp#931 only set topic if it is passed
20f8834
hussfelt added a commit to hussfelt/terraform-provider-aws that referenced this issue Apr 4, 2018
@hussfelt
hashicorp#931 Renaming resources to align with AWS API Resource action
d933edc
hussfelt added a commit to hussfelt/terraform-provider-aws that referenced this issue Apr 4, 2018
@hussfelt
hashicorp#931 Fixing issue with passing the concatenated ID, instead …
7817071 
…of identity
@bflad bflad added this to the v1.14.0 milestone Apr 4, 2018
@bflad
Copy link
Contributor

bflad commented Apr 4, 2018

The new aws_ses_identity_notification_topic resource has been merged into master and will release with v1.14.0 of the AWS provider, likely by the end of the week. Thanks for your patience!

@bflad bflad closed this as completed Apr 4, 2018
@ghost
Copy link

ghost commented Apr 6, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/ses Issues and PRs that pertain to the ses service.
Projects
None yet
Milestone
v1.14.0
Development

Successfully merging a pull request may close this issue.

[WIP/Request Review] New Resource: aws_ses_identity_notification_topic benoj/terraform-provider-aws
3 participants
@bflad @stack72 @benoj